[SOS/DAC] Add tests for DAC GC bugs#5562
Conversation
|
I believe we need to have a scheme to disable this test for versions of the runtime older than .NET 11 (unless of course you intend to fix this in downlevel versions), but this looks generally ok to me. |
diagnostics/src/SOS/SOS.UnitTests/SOS.cs Line 206 in a853665 |
noahfalk
left a comment
There was a problem hiding this comment.
Looks good! Comments inline where I'm hoping we can simplify the config pattern.
| InitializeHandleRoots(); | ||
|
|
||
| int i = _dependentHandles.BinarySearch((source, target)); |
There was a problem hiding this comment.
I found this bug while working on the tests. In some cases, this is not initialized before referencing.
internal_root_arrayruntime#119396