Skip to content

Replace depricated ms.topic: conceptual value with concept-article#105

Merged
jonathanpeppers merged 1 commit intodotnet:mainfrom
wadepickett:wadepickett/mstopicfix
Apr 1, 2026
Merged

Replace depricated ms.topic: conceptual value with concept-article#105
jonathanpeppers merged 1 commit intodotnet:mainfrom
wadepickett:wadepickett/mstopicfix

Conversation

@wadepickett
Copy link
Copy Markdown
Contributor

ms.topic values of conceptual or article are depricated and are to be changed to concept-article.

There was a global setting in the docfx.json in this repo so I changed that from conceptual to concept-article
There were no articles with ms.topic: conceptual or ms.toic: article in this repo.

I am making this fix across several dotnet docs realted repos for the Learn org. Thanks!

@wadepickett wadepickett marked this pull request as ready for review March 31, 2026 18:06
Copilot AI review requested due to automatic review settings March 31, 2026 18:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates DocFX site-wide metadata to align with current Microsoft Learn metadata requirements by replacing the deprecated ms.topic default value.

Changes:

  • Update globalMetadata.ms.topic from conceptual to concept-article in docs/docfx.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wadepickett
Copy link
Copy Markdown
Contributor Author

wadepickett commented Mar 31, 2026

Thanks @adegeo!

@wadepickett
Copy link
Copy Markdown
Contributor Author

This needs to be merged by someone who has the rights to merge. Neither I nor adgeo can merge this to main nor the merge to live step that would happen after that.

@wadepickett
Copy link
Copy Markdown
Contributor Author

wadepickett commented Mar 31, 2026

@davidortinau, can you merge and push this live? Neither adegeo nor I have have rights to merge. Thanks.

@wadepickett
Copy link
Copy Markdown
Contributor Author

@jonathanpeppers, this change in ms.topic values is being made org wide to help reporting services. Neither I nor adegego have merge rights. Could you review and merge to main and then merge to live?

@jonathanpeppers jonathanpeppers merged commit f433833 into dotnet:main Apr 1, 2026
7 of 8 checks passed
@wadepickett
Copy link
Copy Markdown
Contributor Author

Thanks @jonathanpeppers! Does this automatically go to live? Or do we need to manually merge to live?

@wadepickett wadepickett deleted the wadepickett/mstopicfix branch April 1, 2026 21:55
@jonathanpeppers
Copy link
Copy Markdown
Member

@wadepickett there is some pipeline that runs every night, it has been working -- but we can do it manually if it doesn't work by tomorrow morning.

@wadepickett
Copy link
Copy Markdown
Contributor Author

@wadepickett there is some pipeline that runs every night, it has been working -- but we can do it manually if it doesn't work by tomorrow morning.

Cool! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants