Port Xamarin documentation about user notifications to .NET.#66
Port Xamarin documentation about user notifications to .NET.#66davidbritch merged 13 commits intodotnet:mainfrom
Conversation
🚧 Work in progress, no need to review yet 🚧 * Copy existing documentation about notifications to .NET. * Update the actual text a bit to avoid sounding old (phrasing such as "new in iOS 10..." was removed for instance). * Removed instructions for VSMac, added instructions for VSCode. * Misc cleanup.
|
Marking as |
davidbritch
left a comment
davidbritch
left a comment
There was a problem hiding this comment.
I haven't commented on every occurrence of an issue, but there are essentially three issues:
- You need to add user-notifications to the TOC (and index.md if you decide to keep it). Everything has to go in the TOC.
- File/folder names should be italicised rather than treated as code.
- All images need left-aligning with their parent numbered list.
There was a problem hiding this comment.
Is this file needed? Generally we don't bother with index.md files anymore unless they add some unique information that isn't present elsewhere.
There was a problem hiding this comment.
Are there going to be more docs about user notifications? If so, it justifies having a user-notifications folder. If not, you can remove the folder and just have app-fundamentals/user-notifications.md.
There was a problem hiding this comment.
You always need periods on the ends of bullets to make screen readers pause.
There was a problem hiding this comment.
Do I need the period when each bullet point is just a link? For the "See also" section for instance: https://github.com/dotnet/docs-mobile/pull/66/files#diff-ff5d095438ec9514bb6fa8758bec8032bc3ad1b0a9c33b56237307ed7c1561b1R737-R743
There was a problem hiding this comment.
File/folder names should be italicised rather than treated as code.
There was a problem hiding this comment.
File/folder names should be italicised rather than treated as code.
There was a problem hiding this comment.
All these images need indenting so they are left aligned with the numbered list.
|
@davidbritch this can be merged now. |
4 participants
Copy the Xamarin documentation about user notifications, and modify/update/verify it for .NET.
Accompanying sample project: dotnet/macios-samples#3
Templates in progress: dotnet/macios#21886
Internal previews