-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Replace marshalling/marshalled with marshaling/marshaled #12005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -1,18 +1,18 @@ | |||
| --- | |||
| title: Customizing parameter marshalling - .NET | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A file rename results into the link change. That should be "registered" in the redirection file:
https://github.com/dotnet/docs/blob/master/.openpublishing.redirection.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct.
@NextTurn register a redirect in that json file. I'm not sure if you've done that before but put the entries somewhere in the middle of the file, don't append to the end. This helps avoid merge conflicts.
source_path is the file path in the repo of the old file.
redirect_url is the URI after https://docs.microsoft.com/en-us of the new published file.
Do this for each renamed file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put the entries somewhere in the middle of the file, don't append to the end.
Entries are sorted alphabetically by the source_path field.
mairaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NextTurn. This looks great. As @pkulikov mentioned, for the file renames, we need to add the entries to the redirect file at https://github.com/dotnet/docs/blob/master/.openpublishing.redirection.json, where we sort the entries alphabetically by the source_path field. "redirect_document_id" should be true in this case as well.
|
@NextTurn apologies, but it seems we have some merge conflicts here. Can you check? |
|
What does "redirect_document_id" mean? |
|
It's for internal purposes. It tells our BI system to flow the data from the old article to the new one. We don't always want to do that. |
mairaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes @NextTurn. These changes will be going live next week.
Contributes to #11396
Fixes #11986