Skip to content

Conversation

@nxtn
Copy link
Contributor

@nxtn nxtn commented Apr 24, 2019

Contributes to #11396
Fixes #11986

@nxtn nxtn requested a review from Lxiamail as a code owner April 24, 2019 15:11
@@ -1,18 +1,18 @@
---
title: Customizing parameter marshalling - .NET
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A file rename results into the link change. That should be "registered" in the redirection file:
https://github.com/dotnet/docs/blob/master/.openpublishing.redirection.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.

@NextTurn register a redirect in that json file. I'm not sure if you've done that before but put the entries somewhere in the middle of the file, don't append to the end. This helps avoid merge conflicts.

source_path is the file path in the repo of the old file.
redirect_url is the URI after https://docs.microsoft.com/en-us of the new published file.

Do this for each renamed file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put the entries somewhere in the middle of the file, don't append to the end.

Entries are sorted alphabetically by the source_path field.

@mairaw mairaw added this to the April 2019 milestone Apr 25, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NextTurn. This looks great. As @pkulikov mentioned, for the file renames, we need to add the entries to the redirect file at https://github.com/dotnet/docs/blob/master/.openpublishing.redirection.json, where we sort the entries alphabetically by the source_path field. "redirect_document_id" should be true in this case as well.

@mairaw
Copy link
Contributor

mairaw commented Apr 27, 2019

@NextTurn apologies, but it seems we have some merge conflicts here. Can you check?

@nxtn
Copy link
Contributor Author

nxtn commented Apr 28, 2019

What does "redirect_document_id" mean?

@mairaw
Copy link
Contributor

mairaw commented Apr 29, 2019

It's for internal purposes. It tells our BI system to flow the data from the old article to the new one. We don't always want to do that.

@mairaw mairaw changed the base branch from master to staging April 29, 2019 21:20
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes @NextTurn. These changes will be going live next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marshalling vs. Marshaling

4 participants