Serve Model Azure Functions How-To#12012
Conversation
|
Make sure it is clear that these are alternatives Pre-trained model. |
|
This is a real nit but can we indent the code samples to align with the numbered list. I think this would increase readability |
natke
left a comment
There was a problem hiding this comment.
LGTM. A couple of minor comments
|
This is wrong doing that on a static object because the PredictionEngine is not threadsafe. |
|
You could probably use a static PredictionEnginePool because the pool is thread-safe. But I would really prefer to use dependency injection in the Azure Function in a similar way it is explained in this blog post: https://blog.wille-zone.de/post/azure-functions-dependency-injection/ Then, the implementation using PredictionEnginePool would be very similar to the one recommended in ASP.NET Core WebAPI or apps. |
* Merge pull request dotnet#12012 from luisquintanilla/build2019/1484868 Serve Model Azure Functions How-To * Updated with PredictionEnginePool and new model * Updated titles & predictionenginepool description * Updated from data classes to data models * Updates to formatting * Updated based on feedback
Serve Model Azure Functions How-To
Internal Review URL
#AB1484868