URI paths on Unix #20144
Merged
URI paths on Unix #20144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Aug 18, 2020
includes/core-changes/corefx/5.0/non-ascii-chars-in-uri-parsed-correctly.md
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Aug 18, 2020
| Consider the output of the following code when run on Unix. | ||
|
|
||
| ```csharp | ||
| Uri myuri = new Uri("/üri"); |
Member
There was a problem hiding this comment.
I'm unsure if this file will need the BOM character at its beginning or not, since it contains non-ascii (ü).
cc: @sharwell
BillWagner
approved these changes
Aug 19, 2020
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM @gewarren
You can 
when ready.
…-correctly.md Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Youssef1313
requested changes
Aug 20, 2020
| ```csharp | ||
| var myUri = new Uri("/üri"); | ||
|
|
||
| Console.WriteLine(myuri.AbsoluteUri); |
Member
There was a problem hiding this comment.
@gewarren I updated the casing with my suggestion and forgot to do it here and next line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19965.
Preview link.