Fix null forgiving F1 keyword#20341
Merged
Merged
Conversation
Member
Author
|
@BillWagner Once dotnet/roslyn#47516 is reviewed for correctness, this should be ready to merge, then Roslyn's PR. |
davidwengier
approved these changes
Sep 7, 2020
Member
davidwengier
left a comment
There was a problem hiding this comment.
I don't think there is any reason to wait for the Roslyn PR to be approved, having the same f1_keyword in two pages is a problem regardless of whether any code currently points to it.
davidwengier
approved these changes
Sep 7, 2020
Member
davidwengier
left a comment
There was a problem hiding this comment.
I don't think there is any reason to wait for the Roslyn PR to be approved, having the same f1_keyword in two pages is a problem regardless of whether any code currently points to it.
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/roslyn#46988