-
Notifications
You must be signed in to change notification settings - Fork 6.1k
PublishDepsFilePath breaking change #20568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
44d9962
add framework
gewarren c225088
Fixes #20376
gewarren 1d68656
Update includes/core-changes/msbuild/5.0/publishdepsfilepath-behavior…
gewarren 45eeb17
pull upstream master
gewarren c0606cd
Merge branch 'publishdepsfilepath' of github.com:gewarren/docs into p…
gewarren File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
includes/core-changes/msbuild/5.0/publishdepsfilepath-behavior-change.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| ### PublishDepsFilePath behavior change | ||
|
|
||
| The `PublishDepsFilePath` MSBuild property is empty for single-file applications. Additionally, for non single-file applications, the *deps.json* file may not be copied to the output directory until later in the build. | ||
|
|
||
| #### Version introduced | ||
|
|
||
| 5.0 | ||
|
|
||
| #### Change description | ||
|
|
||
| In previous .NET versions, the `PublishDepsFilePath` MSBuild property is the path to the app's *deps.json* file in the output directory for non single-file applications, and a path in the intermediate directory for single-file apps. | ||
|
|
||
| Starting in .NET 5.0, `PublishDepsFilePath` is empty for single-file applications and a new `IntermediateDepsFilePath` property specifies the *deps.json* location in the intermediate directory. Additionally, for non single-file applications, the *deps.json* file may not be copied to the output directory (that is, the path specified by `PublishDepsFilePath`) until later in the build. | ||
|
|
||
| #### Reason for change | ||
|
|
||
| This change was made for a couple of reasons: | ||
|
|
||
| - Due to a refactoring of the publish logic in order to support [improved single-file apps](https://github.com/dotnet/designs/blob/master/accepted/2020/single-file/design.md) in .NET 5. | ||
|
|
||
| - In single-file apps, to help guard against targets that try to rewrite the *deps.json* file after *deps.json* has already been bundled, thus silently not affecting the app. For this reason, `PublishDepsFilePath` is empty for single-file applications. | ||
|
|
||
| #### Recommended action | ||
|
|
||
| Targets that rewrite the *deps.json* file should generally do so using the `IntermediateDepsFilePath` property. | ||
|
|
||
| #### Category | ||
|
|
||
| MSBuild | ||
|
|
||
| #### Affected APIs | ||
|
|
||
| N/A | ||
|
|
||
| <!-- | ||
|
|
||
| #### Affected APIs | ||
|
|
||
| Not detectable via API analysis. | ||
|
|
||
| --> | ||
|
gewarren marked this conversation as resolved.
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.