WinForms breaking change - native code#22576
Merged
gewarren merged 7 commits intodotnet:masterfrom Feb 2, 2021
Merged
Conversation
RussKie
approved these changes
Jan 30, 2021
Contributor
RussKie
left a comment
RussKie
left a comment
There was a problem hiding this comment.
👍
@JeremyKuhne @weltkante could you please review as well
weltkante
reviewed
Jan 30, 2021
weltkante
left a comment
weltkante
left a comment
There was a problem hiding this comment.
I'm not sure if putting the whole rationale for the PR into the docs is "too much information" but otherwise its ok
docs/core/compatibility/windows-forms/5.0/winforms-objects-not-accessible-from-native-code.md
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jan 30, 2021
docs/core/compatibility/windows-forms/5.0/winforms-objects-not-accessible-from-native-code.md
Show resolved
Hide resolved
…-accessible-from-native-code.md Co-authored-by: Tobias Käs <tobias.kaes@gmail.com>
Youssef1313
reviewed
Jan 30, 2021
docs/core/compatibility/windows-forms/5.0/winforms-objects-not-accessible-from-native-code.md
Outdated
Show resolved
Hide resolved
BillWagner
approved these changes
Feb 1, 2021
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This looks great @gewarren
I had one suggestion, based on @Youssef1313 's comment. Then, this is ready to 
docs/core/compatibility/windows-forms/5.0/winforms-objects-not-accessible-from-native-code.md
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22423.
Preview link.