Docs for CA2252

[pgovind]

Documentation for CA2252 behavior. Followed instructions from https://docs.microsoft.com/en-us/contribute/dotnet/dotnet-contribute-code-analysis. Hopefully I got the grammar/formatting rules right!

cc @jeffhandley @terrajobst

[gewarren]

Suggested change

```

[pgovind]

Did you actually mean to delete the ``` here?

[gewarren]

Hmm, this must be a GitHub bug. The actual suggestion is to indent the ``` by two spaces.

[Youssef1313]

@gewarren Using backticks inside backticks don't always work well. Whenever I do suggestions involving backticks I use:

~~~suggestion
suggestion containing ``` here
~~~

instead of

```suggestion
suggestion containing ``` here
```

The following is using ~~~suggestion instead of ``````````suggestion`

Suggested change

	```
	```

Just in case you come across this in future, it has bothered me for long before I knew about the ~~~

[gewarren]

That's awesome, thanks @Youssef1313 !

[gewarren]

Here's the preview if you want to take a look: https://review.docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2252?branch=pr-en-us-26149

[jeffhandley]

I agree with all of @gewarren's suggestions. Assuming those get applied, I have no other feedback. 👍

[jeffhandley]

@pgovind We should include a section about the side effects of <EnablePreviewFeatures>true</> and also cover <GenerateRequiresPreviewFeaturesAttribute> and its behavior. I could even imagine a table that shows the net result of each combination and what scenario the combination is useful for.

This might have helped with dotnet/aspnetcore#36783 (comment).

[gewarren]

I do have a reference section for both of the MSBuild properties. Maybe you can expand those sections and then link to it?

https://docs.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#enablepreviewfeatures

[pgovind]

The markdown leg failure here is unrelated. I made a change to msbuild-props.md in the latest commit. It;s a minor change, should be an easy review.

[gewarren]

Thanks for the ping, I'll merge this now.