X509ChainPolicy verification time #30296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartonjs
reviewed
Jul 20, 2022
docs/core/compatibility/cryptography/7.0/x509chainpolicy-verification-time.md
Show resolved
Hide resolved
bartonjs
approved these changes
Jul 20, 2022
IEvangelist
approved these changes
Jul 21, 2022
Member
IEvangelist
left a comment
IEvangelist
left a comment
There was a problem hiding this comment.
Looks great, just a few nits.
docs/core/compatibility/cryptography/7.0/x509chainpolicy-verification-time.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/cryptography/7.0/x509chainpolicy-verification-time.md
Outdated
Show resolved
Hide resolved
gewarren
commented
Jul 21, 2022
Contributor
Author
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
Taking half of David's suggestions.
docs/core/compatibility/cryptography/7.0/x509chainpolicy-verification-time.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/cryptography/7.0/x509chainpolicy-verification-time.md
Outdated
Show resolved
Hide resolved
gewarren
commented
Jul 25, 2022
Contributor
Author
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
Add back David's request for var.
docs/core/compatibility/cryptography/7.0/x509chainpolicy-verification-time.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/cryptography/7.0/x509chainpolicy-verification-time.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30182
Preview link.