New RateLimiter article showing a custom HTTP handler#31095
Merged
Conversation
IEvangelist
force-pushed
the
rate-limiting
branch
from
dae8fe3 to
bf6a020
Compare
IEvangelist
changed the title
RateLimiter article showing a custom HTTP handler
Member
Author
|
Hey @BillWagner, my only question for you on this is do we need to have something that calls attention to the fact that this is currently using the preview bits for .NET 7? Assuming yes, what is common for conceptual articles like this? |
Contributor
Here's the include file I use at the top of System.CommandLine docs: https://github.com/dotnet/docs/blob/main/includes/scl-preview.md |
BillWagner
approved these changes
Sep 15, 2022
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This looks great @IEvangelist
I found one typo, and had one suggestion to improve clarity. Then, once others are happy, 
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
IEvangelist
added
okr-freshness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New
RateLimiterarticle showing a custom HTTP handlerFixes #30426
Preview