Skip to content

Networking breaking change #31595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gewarren merged 2 commits into from
Oct 5, 2022
Merged

Networking breaking change #31595

gewarren merged 2 commits into from
Oct 5, 2022

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 4, 2022 •
edited
Loading

@dotnet-bot dotnet-bot added this to the October 2022 milestone Oct 4, 2022
@gewarren gewarren requested review from a team and CarnaViire October 4, 2022 21:50
CarnaViire
CarnaViire approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

BillWagner
BillWagner approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 8239d82 into dotnet:main Oct 5, 2022
@gewarren gewarren deleted the connectasync branch October 5, 2022 15:12
@gewarren gewarren added the 🏁 Release: .NET 7 Work items for the .NET 7 release label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

@CarnaViire CarnaViire CarnaViire approved these changes

Assignees

No one assigned

Labels

🏁 Release: .NET 7 Work items for the .NET 7 release dotnet-fundamentals/svc

Projects

None yet

Milestone

October 2022

Development

Successfully merging this pull request may close these issues.

[Breaking change]: ClientWebSocket.ConnectAsync throws ArgumentException on incompatible options

4 participants

@gewarren @BillWagner @CarnaViire @dotnet-bot