Skip to content

WinForms breaking changes for Preview 1 #33798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gewarren merged 7 commits into from
Feb 14, 2023
Merged

WinForms breaking changes for Preview 1 #33798

gewarren merged 7 commits into from
Feb 14, 2023

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Feb 1, 2023 •
edited
Loading

@ghost ghost added the 🏁 Release: .NET 8 Work items for the .NET 8 release label Feb 1, 2023
@dotnet-bot dotnet-bot added this to the February 2023 milestone Feb 1, 2023
@gewarren gewarren requested review from a team and dreddy-work February 1, 2023 04:21
@gewarren gewarren changed the title Two WinForms breaking changes WinForms breaking changes for Preview 1 Feb 6, 2023
@gewarren gewarren requested a review from RussKie February 6, 2023 22:56
adegeo
adegeo approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I however don't know the accuracy of these and @RussKie is probably the better choice for a review 😁

KlausLoeffelmann
KlausLoeffelmann approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, looks good otherwise.

dreddy-work
dreddy-work approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@dreddy-work dreddy-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RLGTM

@gewarren @KlausLoeffelmann @dreddy-work
Apply suggestions from code review
5d683ac 
Co-authored-by: Klaus Löffelmann <9663150+KlausLoeffelmann@users.noreply.github.com>
Co-authored-by: Devendar Reddy Adulla <dreddy@microsoft.com>
@gewarren gewarren enabled auto-merge (squash) February 14, 2023 19:38
@gewarren gewarren merged commit b24d801 into dotnet:main Feb 14, 2023
merriemcgaw
merriemcgaw reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@merriemcgaw merriemcgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KlausLoeffelmann KlausLoeffelmann KlausLoeffelmann approved these changes

@merriemcgaw merriemcgaw merriemcgaw left review comments

@adegeo adegeo adegeo approved these changes

@RussKie RussKie Awaiting requested review from RussKie

+1 more reviewer

@dreddy-work dreddy-work dreddy-work approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🏁 Release: .NET 8 Work items for the .NET 8 release dotnet-fundamentals/svc

Projects

None yet

Milestone

February 2023

6 participants

@gewarren @KlausLoeffelmann @merriemcgaw @dreddy-work @adegeo @dotnet-bot