Fixing FWLinks in Core and FSharp Docs folders #3441
Conversation
|
@xaviex, |
|
@xaviex, |
|
@mairaw In this pull (again sorry about the canceled former one) I believe I have fixed the majority of problems in the original. |
| ``` | ||
|
|
||
| This action sets up a type provider with the database connection that you created earlier. The property `MultipleActiveResultSets` is needed when you use the ADO.NET Entity Framework because this property allows multiple commands to execute asynchronously on the database in one connection, which can occur frequently in ADO.NET Entity Framework code. For more information, see [Multiple Active Result Sets (MARS)](http://go.microsoft.com/fwlink/?LinkId=236929). | ||
| This action sets up a type provider with the database connection that you created earlier. The property `MultipleActiveResultSets` is needed when you use the ADO.NET Entity Framework because this property allows multiple commands to execute asynchronously on the database in one connection, which can occur frequently in ADO.NET Entity Framework code. For more information, see [Multiple Active Result Sets (MARS)](https://docs.microsoft.com/en-us/sql/relational-databases/native-client/features/using-multiple-active-result-sets-mars). |
There was a problem hiding this comment.
instead of https://docs.microsoft.com/en-us/sql/relational-databases/native-client/features/using-multiple-active-result-sets-mars, the link should look like /sql/relational-databases/native-client/features/using-multiple-active-result-sets-mars
This will ensure that it works for offline books and other locales too.
There was a problem hiding this comment.
Okay!, What is the pattern I should look for which should look like this?
There was a problem hiding this comment.
@xaviex for links going to docs.microsoft.com/en-us/xyz should go to /xyz. Except when the xyz is dotnet. Then the preferred way would be ~/docs/<path-after-dotnet>.md
For example, https://docs.microsoft.com/en-us/dotnet/core/docker/ would become ~/docs/core/docker.md
There was a problem hiding this comment.
got it, Implementing this now for future links
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
I'll just wait for the build to finish before merging.
mairaw
added
verify-build-before-merge
✨ 1st-time docs contributor!
|
Thank you @xaviex. This one is good to go. The fix will show up live probably later tonight. |
3 participants
Fixing FWLinks in Core and FSharp docs for clarity
Summary
Replacing FWLinks with their final redirects to provide clarity in links located in the docs
Fixes #3423
Suggested Reviewers
@mairaw
edit by @mairaw: fixed issue number