Skip to content

Dotnet new details command#35919

Merged
tdykstra merged 7 commits intodotnet:mainfrom
maridematte:dotnetNew-detailsCommand
Jul 12, 2023
Merged

Dotnet new details command#35919
tdykstra merged 7 commits intodotnet:mainfrom
maridematte:dotnetNew-detailsCommand

Conversation

@maridematte
Copy link
Copy Markdown
Member

@maridematte maridematte commented Jun 22, 2023

Summary

Added a new page for the dotnet new details command that was implemented here: dotnet/sdk#31743.


Internal previews

📄 File 🔗 Preview link
docs/core/tools/dotnet-new-details.md docs/core/tools/dotnet-new-details

@maridematte maridematte marked this pull request as ready for review July 7, 2023 13:47
@maridematte maridematte requested a review from tdykstra as a code owner July 7, 2023 13:47
Copy link
Copy Markdown
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few minor suggestions, and the article needs to be added to the toc.yml file.

Comment thread docs/core/tools/dotnet-new-details.md Outdated
Comment thread docs/core/tools/dotnet-new-details.md Outdated
Comment thread docs/core/tools/dotnet-new-details.md Outdated
Comment thread docs/core/tools/dotnet-new-details.md Outdated
Comment thread docs/core/tools/dotnet-new-details.md Outdated
Comment thread docs/core/tools/dotnet-new-details.md Outdated
Comment thread docs/core/tools/dotnet-new-details.md Outdated
Comment thread docs/core/tools/dotnet-new-details.md Outdated
Comment thread docs/core/tools/dotnet-new-details.md Outdated
Comment thread docs/core/tools/dotnet-new-details.md Outdated
Copy link
Copy Markdown
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove --version due to dotnet/templating#6811

Comment thread docs/core/tools/dotnet-new-details.md Outdated
Comment thread docs/core/tools/dotnet-new-details.md Outdated
@BillWagner BillWagner modified the milestones: June 2023, July 2023 Jul 11, 2023
@maridematte maridematte requested a review from a team as a code owner July 11, 2023 16:23
Copy link
Copy Markdown
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@maridematte maridematte reopened this Jul 12, 2023
@tdykstra tdykstra merged commit 73a8bea into dotnet:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants