Add a reference for new .NET 8 metrics#37213
Conversation
noahfalk
force-pushed
the
metrics_reference
branch
from
1b2c439 to
57e96f7
Compare
Part of the work for dotnet#36748
noahfalk
force-pushed
the
metrics_reference
branch
from
57e96f7 to
febc02f
Compare
tarekgh
left a comment
tarekgh
left a comment
There was a problem hiding this comment.
The doc structure and template look good to me. I left a couple of questions.
JamesNK
left a comment
JamesNK
left a comment
There was a problem hiding this comment.
Overall, looks good. Needs a thorough edit pass.
|
Thanks for feedback so far! I added the remaining ASP.NET metrics, updated for feedback, and hopefully caught some of the editing issues. |
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
Apologies for the late review. Blocking merge since there is one major inaccuracy.
Co-authored-by: Anton Firszov <antonfir@gmail.com>
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
We need to sync this with the coming System.Net changes, probably easier to do it right in the PR.
If the dotnet doc folks can't do this, @tdykstra and I can help. See open-telemetry/semantic-conventions#283 where @tdykstra and I have made massive edits. |
Done :) |
.NET 9 introduced additions to `System.Net` distributed tracing which define a contract following OTel recommendations: - dotnet/runtime#104251 adjusted the HTTP client request activity so it natively complies with OTel recommendations. This included adding standard tags. - dotnet/runtime#103922 introduced activities breaking down the HTTP connection setup. This PR documents the activities together with their attributes in a manner similar to the metrics docs added by #37213. The matching semconv PR is open-telemetry/semantic-conventions#1192. Conceptual docs are being introduced in #42830. Moreover, the PR also adjusts certain parts of the metrics doc in order to make it more accurate, synchronize it with the activities doc and incorporate the changes from #42810. --------- Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
7 participants
Part of the work for #36748
This is part of new metrics reference material. If the patterns look good I can add the rest, but also happy to shuffle things around. For now I put all the metrics into files within the diagnostics folder, but I can move them anywhere area owners would like them to be. In the future I imagine adding more pages for runtime metrics, Microsoft.Extensions metrics, EF metrics, and potentially any other area of the runtime that adds metrics. The overview admittedly feels a little spartan for now.
@JamesNK @antonfirsov @tarekgh @samsp-msft
Internal previews