Skip to content

Conversation

@BartoszKlonowski
Copy link
Contributor

@BartoszKlonowski BartoszKlonowski commented Sep 23, 2023

This pull request fixes #36648
It updates the description of dotnet-dump's -c option description so that it match the description included in dotnet/diagnostics repo, in diagnostics/scr/Tools/dotnet-dump/Program.cs line 110.

That implementation of the option's description is in another repository, so unfortunately cherry-picking was not an option. I had to copy-paste the description directly from original implementation.


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/dotnet-dump.md Dump collection and analysis utility (dotnet-dump)

@BartoszKlonowski BartoszKlonowski requested review from a team and tommcdon as code owners September 23, 2023 19:32
@dotnet-bot dotnet-bot added this to the September 2023 milestone Sep 23, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Sep 23, 2023
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BartoszKlonowski

This LGTM @BartoszKlonowski

I'll :shipit: now.

@BillWagner BillWagner merged commit adea9ec into dotnet:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dotnet-dump analyze can take multiple commands

3 participants