Skip to content

Fix dotnet-8.md code sample #37330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gewarren merged 2 commits into from
Oct 2, 2023
Merged

Fix dotnet-8.md code sample #37330

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae16c34
Fix dotnet-8.md code sample
eiriktsarpalis Oct 1, 2023
9b298f8
Update docs/core/whats-new/dotnet-8.md
eiriktsarpalis Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/core/whats-new/dotnet-8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ For example, consider the following code that deserializes into a `CustomerInfo`
using System.Text.Json;

CustomerInfo customer =
JsonSerializer.Deserialize<CustomerInfo>("""{"Name":"John Doe","Company":{"Name":"Contoso"}}""")!;
JsonSerializer.Deserialize<CustomerInfo>("""{"Names":["John Doe"],"Company":{"Name":"Contoso"}}""")!;

Console.WriteLine(JsonSerializer.Serialize(customer));

Expand All @@ -187,21 +187,21 @@ class CompanyInfo
class CustomerInfo
{
// Both of these properties are read-only.
public string Name { get; } = "Anonymous";
public List<string> Names { get; } = new();
public CompanyInfo Company { get; } = new() { Name = "N/A", PhoneNumber = "N/A" };
}
```

Prior to .NET 8, the input values were ignored and the `Name` and `Company` properties retained their default values.
Prior to .NET 8, the input values were ignored and the `Names` and `Company` properties retained their default values.

```output
{"Name":"Anonymous","Company":{"Name":"N/A","PhoneNumber":"N/A"}}
{"Names":[],"Company":{"Name":"N/A","PhoneNumber":"N/A"}}
```

Now, the input values are used to populate the read-only properties during deserialization.

```output
{"Name":"John Doe","Company":{"Name":"Contoso","PhoneNumber":null}}
{"Names":["John Doe"],"Company":{"Name":"Contoso","PhoneNumber":null}}
```

#### Disable reflection-based default
Expand Down