Merged
Conversation
- Add docs for that enumeration value in the .NET debugging APIs. - Also updates the CorReferenceFinalizer value. 80000002 in decimal is the correct value in the shipping code. Probably some earlier developer intended it to be hexadecimal in the product but made a mistake. Since it has already shipped it won't be changed. Fixes dotnet/diagnostics#4171
Member
Author
|
@tommcdon PTAL |
Member
Author
|
@gewarren - I see the CI failed, but if I understand it correctly the warning it is complaining about is in a different file that isn't touched by this PR. |
Contributor
gewarren
approved these changes
Sep 19, 2024
hoyosjs
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/diagnostics#4171
Internal previews