Merged
Conversation
liveans
approved these changes
Nov 6, 2024
Member
There was a problem hiding this comment.
Query redaction LGTM, but I believe this also fixes #42792 not #42972
If @antonfirsov also can take a look on query redaction, that would be great.
antonfirsov
approved these changes
Nov 6, 2024
Contributor
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
Query redaction & server.port docs LGTM modulo a minor grammar issue.
docs/core/compatibility/networking/9.0/server-port-attribute.md
Outdated
Show resolved
Hide resolved
gewarren
commented
Nov 6, 2024
docs/core/compatibility/networking/9.0/server-port-attribute.md
Outdated
Show resolved
Hide resolved
antonfirsov
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42824
Fixes #42810
Fixes #42792
Fixes #42794
Internal previews