Distributed tracing in networking#44063
Merged
antonfirsov merged 21 commits intodotnet:mainfrom Jan 29, 2025
Merged
Conversation
3 tasks
antonfirsov
commented
Jan 8, 2025
samsp-msft
approved these changes
Jan 21, 2025
Contributor
samsp-msft
left a comment
There was a problem hiding this comment.
Great content. Lets make the changes to the core telemetry example so you don't need to document how to modify it.
Co-authored-by: Sam Spencer <54915162+samsp-msft@users.noreply.github.com>
Co-authored-by: Sam Spencer <54915162+samsp-msft@users.noreply.github.com>
…/docs into af/network-tracing-2
Contributor
Author
|
@gewarren would you mind doing a language review on this? (Though I think it's mostly ok, so it's optional.) |
gewarren
reviewed
Jan 23, 2025
Contributor
gewarren
left a comment
There was a problem hiding this comment.
I'll wait to review the rest until you've run Acrolinx (see one of the comments I left).
Contributor
Author
gewarren
reviewed
Jan 28, 2025
Contributor
gewarren
left a comment
There was a problem hiding this comment.
I didn't finish reviewing tracing.md, as it seems to duplicate a lot of the content in metrics.md. I'm guessing that's not intentional, so will hold off on reviewing the rest.
gewarren
approved these changes
Jan 28, 2025
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Contributor
Author
|
@gewarren thanks a lot for chiming in, the content looks much better now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major rework of #42830, extending the content, making the information more specific and IMO easier to follow. The biggest change is the in the collection paragraphs:
Metrics.md: Added back thedotnet-monitorexample. Reintroduced a short paragraph on prometheus/grafana, since the referenced docs need some augmentation.Internal previews