-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Remove remaining MSDN link in article #7251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
replace msdn link
rpetrusha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the link, @nemrism. I do have one request for a change that is unrelated to your PR. If you'd prefer, we can make the change.
|
@rpetrusha, do you mean that you'll handle this update in another PR? |
|
Either in this PR or a new PR,, @nemrism. |
|
|
||
| ## Example | ||
| This example code uses `DllImport` to import `winmm.dll`'s `PlaySound` method entry point as `Form1 PlaySound()`. The example has a simple Windows Form with a button. Clicking the button opens a standard windows <xref:System.Windows.Forms.OpenFileDialog> dialog box so that you can open a file to play. When a wave file is selected, it is played by using the `PlaySound()` method of the winmm.DLL assembly method. For more information about winmm.dll's `PlaySound` method, see [Using the PlaySound function with Waveform-Audio Files](https://msdn.microsoft.com/library/aa910379.aspx). Browse and select a file that has a .wav extension, and then click **Open** to play the wave file by using platform invoke. A text box shows the full path of the file selected. | ||
| This example code uses `DllImport` to import `winmm.dll`'s `PlaySound` method entry point as `Form1 PlaySound()`. The example has a simple Windows Form with a button. Clicking the button opens a standard windows <xref:System.Windows.Forms.OpenFileDialog> dialog box so that you can open a file to play. When a wave file is selected, it is played by using the `PlaySound()` method of the winmm.DLL assembly method. For more information about winmm.dll's `PlaySound` method, see [Using the PlaySound function with Waveform-Audio Files](https://docs.microsoft.com/windows/desktop/multimedia/using-playsound-to-play-waveform-audio-files). Browse and select a file that has a .wav extension, and then click **Open** to play the wave file by using platform invoke. A text box shows the full path of the file selected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, @nemrism. My comment was evidently lost. This is unrelated to your PR, but it's a very noticeable error in the original text. winmm.dll is neither an assembly nor a method. Could you change "of the winmm.DLL assembly method" to read "in the winmm.dll assembly"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As winmm.dll isn't an assembly nor a method, should we rather change it to read "of the winmm.dll library"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either "in" of "of" is fine.
`winmm.dll` isn't an assembly nor a method
|
I apologize, @nemrism. I'd meant to merge this three days ago. I'll merge it now, and it should be live on docs.microsoft.com in the next day or two. |
Replace msdn link in how-to-use-platform-invoke-to-play-a-wave-file.md
Contributes to #2037