Add a new csharp file#9368
Merged
BillWagner merged 3 commits intodotnet:masterfrom Dec 5, 2018
kendrahavens:patch-1
Merged
Conversation
BillWagner
approved these changes
Dec 4, 2018
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This is a great addition @kendrahavens
I had one suggestion, if you wanted to update the code before you 
. Overall, LGTM.
pkulikov
reviewed
Dec 4, 2018
Contributor
Author
|
@BillWagner or @mairaw I don't have permissions to merge. Thank you for reviewing! |
mairaw
reviewed
Dec 5, 2018
| > [!TIP] | ||
| > For more information and troubleshooting tips on .NET Core debugging with OmniSharp in Visual Studio Code, see [Instructions for setting up the .NET Core debugger](https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger.md). | ||
|
|
||
| ## Add a Class |
Contributor
There was a problem hiding this comment.
Sentence case for headings
Suggested change
| ## Add a Class | |
| ## Add a class |
I can merge for you and add VB later.
Contributor
Author
There was a problem hiding this comment.
Yay! Thank you!
mairaw
reviewed
Dec 5, 2018
| @@ -82,6 +82,50 @@ You can also watch a short video tutorial for further setup help on [Windows](ht | |||
| > [!TIP] | |||
Contributor
There was a problem hiding this comment.
also ms.date on line 6 should be updated.
Contributor
Author
|
Thank you all!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a section on how to add a new .cs file to a project. If approved, we should add the same to the VB doc.
Fixes #9155
Reviewers
@KathleenDollard