CoreCLR: Automatically port System.GC* triple slash comments to Docs #2759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
requested review from
a user,
VSadov,
jkotas,
luhenry,
mairaw,
rpetrusha and
stephentoub
carlossanlop
added
🏁 Release: .NET Core 3.0
carlossanlop
commented
Jul 15, 2019
VSadov
approved these changes
Jul 15, 2019
Member
VSadov
left a comment
VSadov
left a comment
There was a problem hiding this comment.
Can't comment on style, but technically the comments look correct.
VSadov
reviewed
Jul 15, 2019
ghost
approved these changes
Jul 15, 2019
added 2 commits
July 16, 2019 12:08
rpetrusha
approved these changes
Jul 16, 2019
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
I've made a number of changes, @carlossanlop. Please review them before I merge.
rpetrusha
added
verify-build-before-merge
and removed
waiting-on-reviews
Contributor
Author
|
@rpetrusha thanks for your changes, they look good to me. I think this is ready to merge. |
|
Thanks, @carlossanlop. I'll merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some triple slash comments in Garbage Collection related APIs that could be automatically ported.
issue-guide.md is not clear about the ownership of these APIs, so I'm going to ask the people who have modified these APIs most recently to take a look or help me find the right owner:
@luhenry @VSadov @stephentoub @jkotas @Andy-MS
@rpetrusha @mairaw for language review.