Fix misleading wording in PipeReader and PipeWriter's AsStream documentation. #4156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 23, 2020 17:07
The old wording gets it exactly wrong - the PipeReader doesn't wrap the Stream, the Stream wraps the PipeReader.
benjamin-hodgson
requested review from
analogrelay,
halter73 and
jkotalik
as code owners
halter73
reviewed
Apr 28, 2020
halter73
reviewed
Apr 28, 2020
Co-Authored-By: Stephen Halter <halter73@gmail.com>
halter73
approved these changes
May 1, 2020
gewarren
reviewed
Jun 22, 2020
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Contributor
|
@benjamin-hodgson Thanks for fixing this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old wording had it exactly wrong - the Pipe doesn't wrap the Stream, the Stream wraps the Pipe.