Update PipeReader.xml to add info to AdvanceTo #4311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update PipeReader.xml to add documentation to AdvanceTo to add information regarding the issue in dotnet/runtime#37176.
halter73
reviewed
Jun 1, 2020
halter73
reviewed
Jun 1, 2020
halter73
reviewed
Jun 1, 2020
halter73
reviewed
Jun 1, 2020
Co-authored-by: Stephen Halter <halter73@gmail.com>
Co-authored-by: Stephen Halter <halter73@gmail.com>
Contributor
Author
|
I cannot find out how to edit this PR to remove the references to the linked github issues as suggested by @halter73. Please help me out o this. |
Contributor
Author
Figured it out. |
Contributor
Author
|
Anything more to be done from my side to close this? |
gewarren
requested changes
Jun 22, 2020
Contributor
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
I found a couple typos.
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Contributor
Author
Committed the corrections |
gewarren
reviewed
Jun 23, 2020
gewarren
approved these changes
Jun 23, 2020
Contributor
Author
|
Thank you. This was my first contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PipeReader.xml to add documentation to AdvanceTo to add information regarding the issue in dotnet/runtime#37176.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)