Skip to content

Conversation

@tdykstra
Copy link
Contributor

Fixes dotnet/docs#10203

From the issue:

Type Replacement type
RIPEMD160 SHA256
MacTripleDes HMACSHA256
HMACSHA1 HMACSHA256

Notes:

@tdykstra tdykstra requested a review from bartonjs June 18, 2020 20:11
@dotnet-bot dotnet-bot added this to the June 2020 milestone Jun 18, 2020
@bartonjs
Copy link
Member

Replaced HMACSHA1 with HMACSHA256 in code examples except where constructor that takes two arguments is called

The second argument is ignored in .NET Core, just replace it with new HMACSHA256(theFirstArgument)

@tdykstra
Copy link
Contributor Author

The second argument is ignored in .NET Core, just replace it with new HMACSHA256(theFirstArgument)

I took another look at this code file, and it specifies SHA1 in several places, not just by using HMACSHA1. One that it's not obvious how to fix is where it defines a URI for SHA1:

{
    public const string PSHA1 = "http://schemas.xmlsoap.org/ws/2005/02/trust/CK/PSHA1";
}

In the other place where it specifies SHA1 the equivalent SHA256 values are clear.

Also, it turns out that the parts of the code file that specify SHA1 are not included in any snippet shown on the site. Only a small portion of this very large file is shown, as seen here.

@tdykstra tdykstra merged commit 0a52719 into dotnet:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

**Replace usage of selected cryptographic types**

3 participants