mdoc updates 5.7.6 #4430
Merged
mdoc updates 5.7.6 #4430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewarren
commented
Jun 23, 2020
| @@ -26,8 +26,7 @@ | |||
| </AssemblyInfo> | |||
| <TypeForwardingChain> | |||
| <TypeForwarding From="System.ServiceModel" FromVersion="4.0.0.0" To="System.ServiceModel.Primitives" ToVersion="4.6.0.0" FrameworkAlternate="dotnet-plat-ext-2.1;dotnet-plat-ext-2.2;dotnet-plat-ext-3.0" /> | |||
| <TypeForwarding From="System.ServiceModel" FromVersion="4.0.0.0" To="System.ServiceModel.Primitives" ToVersion="4.7.0.0" FrameworkAlternate="dotnet-plat-ext-3.1" /> | |||
| <TypeForwarding From="System.ServiceModel" FromVersion="4.0.0.0" To="System.ServiceModel.Primitives" ToVersion="5.0.0.0" FrameworkAlternate="dotnet-plat-ext-5.0" /> | |||
Contributor
Author
There was a problem hiding this comment.
Does this look expected?
gewarren
commented
Jun 23, 2020
gewarren
commented
Jun 23, 2020
Contributor
Author
|
The warnings for unresolved types will be fixed by Multiple Return Type causes build warnings and Handle return types that are private. I think this is good to merge. @BillWagner do you approve? |
BillWagner
approved these changes
Jun 24, 2020
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM. You can 
when ready @gewarren
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.