Skip to content

Conversation

@deisterhold
Copy link

Summary

Make the letter o uppercase.

Fixes #Issue_Number (if available)

@dotnet-bot dotnet-bot added this to the July 2020 milestone Jul 6, 2020
@mairaw
Copy link
Contributor

mairaw commented Jul 8, 2020

Thanks @deisterhold. I agree that would be the appropriate name but on docs we need to show what's in the source code:
https://source.dot.net/#System.Data.Common/System/Data/IDataRecord.cs,22

For this reason, I'm closing this PR. You could file an issue at https://github.com/dotnet/runtime/issues and see if they would take this change. And then docs would automatically get the update.

@mairaw mairaw closed this Jul 8, 2020
@deisterhold
Copy link
Author

@mairaw Ok, thanks. I guess I was looking at the implementation and assumed they were the same.

@deisterhold deisterhold deleted the patch-1 branch July 8, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants