Skip to content

Conversation

@aik-jahoda
Copy link
Contributor

</ReturnValue>
<Docs>
<summary>To be added.</summary>
<summary>Defines a <see cref="T:System.Version" /> instance for HTTP/3.</summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed whole member section

@opbld34
Copy link

opbld34 commented Aug 27, 2020

Docs Build status updates of commit 04a3aab:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net/HttpVersion.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@aik-jahoda aik-jahoda changed the title Add missing api for System.Net.HttpVersion Add missing api doc for System.Net.HttpVersion Aug 28, 2020
@aik-jahoda aik-jahoda force-pushed the jajahoda/HttpVersion branch from 11bed03 to 8cfcdd2 Compare August 28, 2020 13:28
@opbld30
Copy link

opbld30 commented Aug 28, 2020

Docs Build status updates of commit 11bed03:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error-GitCommitDoesNotExist] Cannot sync git repo to specified commit because commit 11bed03caf83e29830ca4ce8c71aa240dc389f19 doesn't exist. It might be caused your branch is deleted or force pushed. If it is not this case, please open a ticket on https://SiteHelp

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@aik-jahoda aik-jahoda force-pushed the jajahoda/HttpVersion branch from 8cfcdd2 to 83bc3b1 Compare August 28, 2020 13:30
@opbld31
Copy link

opbld31 commented Aug 28, 2020

Docs Build status updates of commit 8cfcdd2:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error-GitCommitDoesNotExist] Cannot sync git repo to specified commit because commit 8cfcdd22d949a27fb43f8c3fbabc4bdb20151860 doesn't exist. It might be caused your branch is deleted or force pushed. If it is not this case, please open a ticket on https://SiteHelp

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content-wise LGTM.

<remarks>To be added.</remarks>
</Docs>
</Member>
</Member>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how docs and auto-generating tools will handle this removal.
Maybe it should be left with To be added. (which is skipped) until auto-removed. If that's what the tool will do once it sees the property is gone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the tool will recreate the section once it discover the api again. By the way it should also fill comments from /// in code during first run.

@carlossanlop am I right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove APIs manually.

If this is an API that has been removed from runtime, then we have to wait for the MS Docs build system to catch up and remove it automatically.

Is this API gone in Preview8 or above? Because we haven't updated MS Docs yet with that preview.

@opbld30
Copy link

opbld30 commented Aug 28, 2020

Docs Build status updates of commit 83bc3b1:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net/HttpVersion.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop carlossanlop requested a review from a team August 31, 2020 23:13
@carlossanlop
Copy link
Contributor

I'm closing this PR since we should not manually modify the autogenerated xmls.

@aik-jahoda aik-jahoda deleted the jajahoda/HttpVersion branch September 2, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants