-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add missing api doc for System.Net.HttpVersion #4732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xml/System.Net/HttpVersion.xml
Outdated
| </ReturnValue> | ||
| <Docs> | ||
| <summary>To be added.</summary> | ||
| <summary>Defines a <see cref="T:System.Version" /> instance for HTTP/3.</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed whole member section
|
Docs Build status updates of commit 04a3aab: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
11bed03 to
8cfcdd2
Compare
|
Docs Build status updates of commit 11bed03: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
8cfcdd2 to
83bc3b1
Compare
|
Docs Build status updates of commit 8cfcdd2: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
ManickaP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content-wise LGTM.
| <remarks>To be added.</remarks> | ||
| </Docs> | ||
| </Member> | ||
| </Member> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how docs and auto-generating tools will handle this removal.
Maybe it should be left with To be added. (which is skipped) until auto-removed. If that's what the tool will do once it sees the property is gone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the tool will recreate the section once it discover the api again. By the way it should also fill comments from /// in code during first run.
@carlossanlop am I right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove APIs manually.
If this is an API that has been removed from runtime, then we have to wait for the MS Docs build system to catch up and remove it automatically.
Is this API gone in Preview8 or above? Because we haven't updated MS Docs yet with that preview.
|
Docs Build status updates of commit 83bc3b1: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
I'm closing this PR since we should not manually modify the autogenerated xmls. |
part of: dotnet/runtime#41446