Improve FileSystemWatcher examples #5314
Conversation
ghost
added
the
area-System.Security
|
Docs Build status updates of commit ed157b8: ✅ Validation status: passedFor more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
| Console.WriteLine($"File: {e.FullPath} {e.ChangeType}"); | ||
| private static void OnChanged(object sender, FileSystemEventArgs e) | ||
| { | ||
| if (e.ChangeType != WatcherChangeTypes.Changed) |
There was a problem hiding this comment.
I discovered that the OnChanged event method gets called on any change type. The only one I care about in my example is Changed.
There was a problem hiding this comment.
Was this with .NET Core / .NET 5? I don't think this should be possible with .NET 5.
The Windows, Linux and Mac implementations all raise the Changed event with NotifyFileSystemEventArgs():
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @carlossanlop !
samples/snippets/cpp/VS_Snippets_CLR_Classic/classic NotifyFilters Example/CPP/source.cpp
Show resolved
Hide resolved
samples/snippets/cpp/VS_Snippets_CLR_Classic/classic NotifyFilters Example/CPP/source.cpp
Show resolved
Hide resolved
|
Docs Build status updates of commit 66494b1: ✅ Validation status: passedFor more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Looks good now in the preview. |
7 participants
Like with previous PRs, I am trying to improve our System.IO examples and make sure we only test the relevant code.
I am removing comments too, I felt they were redundant, but if you think a comment would be helpful, let me know.
I ensured they all compiled and executed successfully.