Skip to content

Conversation

@carlossanlop
Copy link
Contributor

Moving lengthy remarks from APIs that belong System.IO.Compression assembly, into their own md files.

Excludes Compression.ZipFile and Compression.Brotli.

Compression.ZipFile assembly addressed separately: #5363

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@opbld33
Copy link

opbld33 commented Mar 3, 2021

Docs Build status updates of commit 08dfa2c:

✅ Validation status: passed

File Status Preview URL Details
includes/remarks/System.IO.Compression/CompressionLevel/CompressionLevel.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionLevel_Boolean.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionMode.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionMode_Boolean.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/BeginRead_Byte_Int32_Int32_AsyncCallback_Object.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/BeginWrite_Byte_Int32_Int32_AsyncCallback_Object.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/DeflateStream.md ✅Succeeded View
includes/remarks/System.IO.Compression/GZipStream/BeginRead_Byte_Int32_Int32_AsyncCallback_Object.md ✅Succeeded View
includes/remarks/System.IO.Compression/GZipStream/GZipStream.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchive/.ctor_Stream_ZipArchiveMode_Boolean_Encoding.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchive/ZipArchive.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveEntry/FullName.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveEntry/LastWriteTime.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveEntry/Name.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveEntry/ZipArchiveEntry.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveMode/ZipArchiveMode.md ✅Succeeded View
xml/System.IO.Compression/CompressionLevel.xml ✅Succeeded View
xml/System.IO.Compression/DeflateStream.xml ✅Succeeded View
xml/System.IO.Compression/GZipStream.xml ✅Succeeded View
xml/System.IO.Compression/ZipArchive.xml ✅Succeeded View
xml/System.IO.Compression/ZipArchiveEntry.xml ✅Succeeded View
xml/System.IO.Compression/ZipArchiveMode.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Mar 3, 2021

Docs Build status updates of commit 08dfa2c:

✅ Validation status: passed

File Status Preview URL Details
includes/remarks/System.IO.Compression/CompressionLevel/CompressionLevel.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionLevel_Boolean.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionMode.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionMode_Boolean.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/BeginRead_Byte_Int32_Int32_AsyncCallback_Object.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/BeginWrite_Byte_Int32_Int32_AsyncCallback_Object.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/DeflateStream.md ✅Succeeded View
includes/remarks/System.IO.Compression/GZipStream/BeginRead_Byte_Int32_Int32_AsyncCallback_Object.md ✅Succeeded View
includes/remarks/System.IO.Compression/GZipStream/GZipStream.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchive/.ctor_Stream_ZipArchiveMode_Boolean_Encoding.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchive/ZipArchive.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveEntry/FullName.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveEntry/LastWriteTime.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveEntry/Name.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveEntry/ZipArchiveEntry.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveMode/ZipArchiveMode.md ✅Succeeded View
xml/System.IO.Compression/CompressionLevel.xml ✅Succeeded View
xml/System.IO.Compression/DeflateStream.xml ✅Succeeded View
xml/System.IO.Compression/GZipStream.xml ✅Succeeded View
xml/System.IO.Compression/ZipArchive.xml ✅Succeeded View
xml/System.IO.Compression/ZipArchiveEntry.xml ✅Succeeded View
xml/System.IO.Compression/ZipArchiveMode.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Mar 3, 2021

Docs Build status updates of commit 66227e8:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error-GitCommitDoesNotExist] Cannot sync git repo to specified commit because commit 66227e88673b7a47f77effe840ae9a9cc4fc95e1 doesn't exist. It might be caused your branch is deleted or force pushed. If it is not this case, please open a ticket on https://SiteHelp

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@carlossanlop
Copy link
Contributor Author

Sorry for the spam, everyone. I pushed the wrong thing and a bunch of unrelated files got added to the PR which triggered the bot to add the owners.

@opbld31
Copy link

opbld31 commented Mar 4, 2021

Docs Build status updates of commit bfcfba0:

✅ Validation status: passed

File Status Preview URL Details
includes/remarks/System.IO.Compression/CompressionLevel/CompressionLevel.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionLevel_Boolean.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionMode.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionMode_Boolean.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/BeginRead_Byte_Int32_Int32_AsyncCallback_Object.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/BeginWrite_Byte_Int32_Int32_AsyncCallback_Object.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/DeflateStream.md ✅Succeeded View
includes/remarks/System.IO.Compression/GZipStream/BeginRead_Byte_Int32_Int32_AsyncCallback_Object.md ✅Succeeded View
includes/remarks/System.IO.Compression/GZipStream/GZipStream.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchive/.ctor_Stream_ZipArchiveMode_Boolean_Encoding.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchive/ZipArchive.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveEntry/FullName.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveEntry/LastWriteTime.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveEntry/Name.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveEntry/ZipArchiveEntry.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipArchiveMode/ZipArchiveMode.md ✅Succeeded View
xml/System.IO.Compression/CompressionLevel.xml ✅Succeeded View
xml/System.IO.Compression/DeflateStream.xml ✅Succeeded View
xml/System.IO.Compression/GZipStream.xml ✅Succeeded View
xml/System.IO.Compression/ZipArchive.xml ✅Succeeded View
xml/System.IO.Compression/ZipArchiveEntry.xml ✅Succeeded View
xml/System.IO.Compression/ZipArchiveMode.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop carlossanlop merged commit 96b853d into dotnet:master Mar 4, 2021
@carlossanlop carlossanlop deleted the CompressionBackport branch March 4, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants