Skip to content

Update DualMode default#5492

Merged
gewarren merged 4 commits intodotnet:mainfrom
gewarren:sockets2
Apr 7, 2021
Merged

Update DualMode default#5492
gewarren merged 4 commits intodotnet:mainfrom
gewarren:sockets2

Conversation

@gewarren
Copy link
Copy Markdown
Contributor

@gewarren gewarren commented Mar 31, 2021

@gewarren gewarren requested a review from a team as a code owner March 31, 2021 16:57
@gewarren gewarren requested a review from antonfirsov March 31, 2021 16:57
@opbld34
Copy link
Copy Markdown

opbld34 commented Mar 31, 2021

Docs Build status updates of commit b9e944a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/Socket.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Copy Markdown
Contributor

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions to be more accurate with terminology.

Shouldn't we also document the NotSupportedExceptions? (Note: we may want to remove the exception being thrown from the getter in .NET 6.0, so it might make sense to defer that work until that point.)

Comment thread xml/System.Net.Sockets/Socket.xml Outdated
Comment thread xml/System.Net.Sockets/Socket.xml Outdated
@antonfirsov
Copy link
Copy Markdown
Contributor

antonfirsov commented Apr 1, 2021

Actually, to really fix the doc issue posted on the Azure DevOps, we need to document the exception behavior as well. We can change the docs later if we decide to alter the behavior for .NET 6.0.

The current behavior:
an attempt to get set the property on a non-IPv6 socket will throw NotSupportedException.

Comment thread xml/System.Net.Sockets/Socket.xml Outdated
Comment thread xml/System.Net.Sockets/Socket.xml Outdated
@gewarren gewarren closed this Apr 5, 2021
@gewarren gewarren reopened this Apr 5, 2021
@opbld34
Copy link
Copy Markdown

opbld34 commented Apr 5, 2021

Docs Build status updates of commit d74c277:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/Socket.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Copy Markdown
Contributor

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed one minor mistake, otherwise looks good.

Comment thread xml/System.Net.Sockets/Socket.xml
@opbld30
Copy link
Copy Markdown

opbld30 commented Apr 6, 2021

Docs Build status updates of commit 18c7a4a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/Socket.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Copy Markdown
Contributor

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 18c7a4a can be reverted.

@opbld32
Copy link
Copy Markdown

opbld32 commented Apr 7, 2021

Docs Build status updates of commit 0728255:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/Socket.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit 9227496 into dotnet:main Apr 7, 2021
@gewarren gewarren deleted the sockets2 branch April 7, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants