Update ICustomMarshaler docs to talk a little bit about interaction with SetLastError #6880
Conversation
…ith SetLastError Contributes to dotnet/runtime#39606
jkoritzinsky
changed the title
Co-authored-by: Elinor Fung <elfung@microsoft.com>
|
Docs Build status updates of commit 2c9d6ac:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| xml/System.Runtime.InteropServices/ICustomMarshaler.xml | View | Details |
xml/System.Runtime.InteropServices/ICustomMarshaler.xml
- Line 0, Column 0: [Warning-xref-not-found]
Cross reference not found: 'System.Runtime.InteropServices.Marshal.GetLastPInvokeError'. - Line 0, Column 0: [Warning-xref-not-found]
Cross reference not found: 'System.Runtime.InteropServices.Marshal.GetLastPInvokeError'. - Line 0, Column 0: [Warning-xref-not-found]
Cross reference not found: 'System.Runtime.InteropServices.Marshal.SetLastPInvokeError'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
|
It looks like the docs don't have entries for Get/SetLastPInvokeError for some reason... |
|
Looks like the docs are currently .NET 6.0 Preview 3 (which doesn't have @gewarren would you be the one that knows what the expectation and process is for what preview version the docs target? |
|
@safern provides me with the reference assemblies for the preview releases. We were hoping to update for Preview 4 but he was out on leave. Santi, it would be good to update these again for Preview 6. |
|
Docs Build status updates of commit a2ff349:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| xml/System.Runtime.InteropServices/ICustomMarshaler.xml | View | Details |
xml/System.Runtime.InteropServices/ICustomMarshaler.xml
- Line 0, Column 0: [Warning-xref-not-found]
Cross reference not found: 'System.Runtime.InteropServices.Marshal.GetLastPInvokeError'. - Line 0, Column 0: [Warning-xref-not-found]
Cross reference not found: 'System.Runtime.InteropServices.Marshal.GetLastPInvokeError'. - Line 0, Column 0: [Warning-xref-not-found]
Cross reference not found: 'System.Runtime.InteropServices.Marshal.SetLastPInvokeError'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
|
After #6890 is merged, this should be updated from main. Then the validation should come back green. |
|
Docs Build status updates of commit a2ff349:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| xml/System.Runtime.InteropServices/ICustomMarshaler.xml | View | Details |
xml/System.Runtime.InteropServices/ICustomMarshaler.xml
- Line 0, Column 0: [Warning-xref-not-found]
Cross reference not found: 'System.Runtime.InteropServices.Marshal.GetLastPInvokeError'. - Line 0, Column 0: [Warning-xref-not-found]
Cross reference not found: 'System.Runtime.InteropServices.Marshal.GetLastPInvokeError'. - Line 0, Column 0: [Warning-xref-not-found]
Cross reference not found: 'System.Runtime.InteropServices.Marshal.SetLastPInvokeError'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
|
Docs Build status updates of commit acf665e: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Fixes dotnet/runtime#39606