Skip to content

Conversation

@CorruptComputer
Copy link
Contributor

Summary

Fixes formatting of String.Remove() C# examples.
Examples shown on this page: https://docs.microsoft.com/en-us/dotnet/api/system.string.remove?view=net-5.0

@dnfadmin
Copy link

dnfadmin commented Sep 27, 2021

CLA assistant check
All CLA requirements met.

@ghost ghost added the area-System.Runtime label Sep 27, 2021
@CorruptComputer CorruptComputer changed the title Fix formatting of String.Remove() code examples Fix formatting of String.Remove() C# code examples Sep 27, 2021
@opbld32
Copy link

opbld32 commented Sep 27, 2021

Docs Build status updates of commit 880241b:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/VS_Snippets_CLR/string.remove/CS/r.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR/stringremove/CS/stringremove.cs ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop
Copy link
Contributor

Thank you!

@CorruptComputer
Copy link
Contributor Author

@carlossanlop No problem, happy to get these fixed. That formatting has been bothering me for awhile now.

I see that one of the checks failed though, is there anything I need to do to get that resolved?

@carlossanlop
Copy link
Contributor

I see that one of the checks failed though, is there anything I need to do to get that resolved?

There is a new requirement to add a csproj in the same folder where a code snippet file exists, so that it gets built and we verify the code is valid.

You can consider this optional, since it's an unrelated requirement for your change, plus the changes you made clearly are not adding syntax errors.

I'll merge this, but if you'd like to add a csproj for all the string cs files in a separate PR, you're welcome to do so. One of the advantages of adding a csproj is that it can target net6.0 and we can apply all the suggestions flagged by Roslyn analyzers, which would make the code even cleaner.

@carlossanlop carlossanlop merged commit c8aae43 into dotnet:main Oct 13, 2021
@CorruptComputer
Copy link
Contributor Author

[...] if you'd like to add a csproj for all the string cs files in a separate PR, you're welcome to do so. One of the advantages of adding a csproj is that it can target net6.0 and we can apply all the suggestions flagged by Roslyn analyzers, which would make the code even cleaner.

@carlossanlop Working on that now, started a draft PR at #7288. Please let me know if it looks like I'll need any other changes. The csproj file I'm working with there is just the default one created by VS, so if it needs anything else to work properly I can add it in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants