Skip to content

System.IO.Compression.DeflateStream examples update #7265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carlossanlop merged 6 commits into from
Oct 5, 2021
Merged

System.IO.Compression.DeflateStream examples update #7265

carlossanlop merged 6 commits into from
Oct 5, 2021

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Oct 3, 2021

Refreshed and simplified the DeflateStream examples, and updated all references.

Made sure to show usage with CompressionLevel, CompressionMode, FileStream and MemoryStream.

@carlossanlop carlossanlop self-assigned this Oct 3, 2021
@ghost
Copy link

ghost commented Oct 3, 2021

Tagging subscribers to this area: @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

Refreshed and simplified the DeflateStream examples, and updated all references.

Made sure to show usage with CompressionLevel, CompressionMode, FileStream and MemoryStream.

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-System.IO.Compression
Milestone: -

@opbld32

This comment has been minimized.

Sign in to view
carlossanlop
carlossanlop commented Oct 3, 2021
View reviewed changes
@opbld33

This comment has been minimized.

Sign in to view
@opbld30

This comment has been minimized.

Sign in to view
@opbld31
Copy link

opbld31 commented Oct 3, 2021

Docs Build status updates of commit c4f7c47:

⚠️ Validation status: warnings

File Status Preview URL Details
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionLevel.md ⚠️Warning View Details
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionMode.md ⚠️Warning View Details
includes/remarks/System.IO.Compression/DeflateStream/DeflateStream.md ⚠️Warning View Details
xml/System.IO.Compression/DeflateStream.xml ⚠️Warning View Details
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionLevel_Boolean.md ✅Succeeded
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionMode_Boolean.md ✅Succeeded
samples/snippets/csharp/System.IO.Compression/Deflate/Deflate.csproj ✅Succeeded
samples/snippets/csharp/System.IO.Compression/Deflate/FileCompressionLevelExample.cs ✅Succeeded View
samples/snippets/csharp/System.IO.Compression/Deflate/FileCompressionModeExample.cs ✅Succeeded
samples/snippets/csharp/System.IO.Compression/Deflate/MemoryWriteReadExample.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR/IO.Compression.Deflate1/CS/deflatetest.cs ✅Succeeded
samples/snippets/csharp/VS_Snippets_CLR_System/system.io.compression.deflatestream/cs/program1.cs ✅Succeeded
samples/snippets/csharp/VS_Snippets_CLR_System/system.io.compression.deflatestream/cs/program2.cs ✅Succeeded
samples/snippets/csharp/VS_Snippets_CLR_System/system.io.compression.deflatestream/cs/program3.cs ✅Succeeded
samples/snippets/visualbasic/System.IO.Compression/Deflate/Deflate.vbproj ✅Succeeded
samples/snippets/visualbasic/System.IO.Compression/Deflate/FileCompressionLevelExample.vb ✅Succeeded View
samples/snippets/visualbasic/System.IO.Compression/Deflate/FileCompressionModeExample.vb ✅Succeeded View
samples/snippets/visualbasic/System.IO.Compression/Deflate/MemoryWriteReadExample.vb ✅Succeeded View
samples/snippets/visualbasic/VS_Snippets_CLR/IO.Compression.Deflate1/VB/deflatetest.vb ✅Succeeded
samples/snippets/visualbasic/VS_Snippets_CLR_System/system.io.compression.deflatestream/vb/program1.vb ✅Succeeded
samples/snippets/visualbasic/VS_Snippets_CLR_System/system.io.compression.deflatestream/vb/program2.vb ✅Succeeded
samples/snippets/visualbasic/VS_Snippets_CLR_System/system.io.compression.deflatestream/vb/program3.vb ✅Succeeded

includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionLevel.md

  • Line 7, Column 1: [Warning-invalid-code] It looks like your code snippet was not rendered. Try range instead.
  • Line 8, Column 1: [Warning-invalid-code] It looks like your code snippet was not rendered. Try range instead.

includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionMode.md

  • Line 13, Column 1: [Warning-invalid-code] The code snippet "~/samples/snippets/visualbasic/System.IO.Compression/Deflate/FileCompressionModeExample.cs" could not be found.

includes/remarks/System.IO.Compression/DeflateStream/DeflateStream.md

  • Line 13, Column 1: [Warning-invalid-code] The code snippet "~/samples/snippets/visualbasic/System.IO.Compression/Deflate/FileCompressionModeExample.cs" could not be found.

xml/System.IO.Compression/DeflateStream.xml

  • Line 0, Column 0: [Warning-invalid-code] It looks like your code snippet was not rendered. Try range instead.
  • Line 0, Column 0: [Warning-invalid-code] It looks like your code snippet was not rendered. Try range instead.
  • Line 0, Column 0: [Warning-invalid-code] It looks like your code snippet was not rendered. Try range instead.
  • Line 0, Column 0: [Warning-invalid-code] It looks like your code snippet was not rendered. Try range instead.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

gewarren
gewarren reviewed Oct 4, 2021
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix all the warnings/suggestions.

@carlossanlop @gewarren
Apply suggestions from code review
fa4628b 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld32
Copy link

opbld32 commented Oct 4, 2021

Docs Build status updates of commit fa4628b:

✅ Validation status: passed

File Status Preview URL Details
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionLevel.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionLevel_Boolean.md ✅Succeeded
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionMode.md ✅Succeeded View
includes/remarks/System.IO.Compression/DeflateStream/.ctor_Stream_CompressionMode_Boolean.md ✅Succeeded
includes/remarks/System.IO.Compression/DeflateStream/DeflateStream.md ✅Succeeded View
samples/snippets/csharp/System.IO.Compression/Deflate/Deflate.csproj ✅Succeeded
samples/snippets/csharp/System.IO.Compression/Deflate/FileCompressionLevelExample.cs ✅Succeeded View
samples/snippets/csharp/System.IO.Compression/Deflate/FileCompressionModeExample.cs ✅Succeeded View
samples/snippets/csharp/System.IO.Compression/Deflate/MemoryWriteReadExample.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR/IO.Compression.Deflate1/CS/deflatetest.cs ✅Succeeded
samples/snippets/csharp/VS_Snippets_CLR_System/system.io.compression.deflatestream/cs/program1.cs ✅Succeeded
samples/snippets/csharp/VS_Snippets_CLR_System/system.io.compression.deflatestream/cs/program2.cs ✅Succeeded
samples/snippets/csharp/VS_Snippets_CLR_System/system.io.compression.deflatestream/cs/program3.cs ✅Succeeded
samples/snippets/visualbasic/System.IO.Compression/Deflate/Deflate.vbproj ✅Succeeded
samples/snippets/visualbasic/System.IO.Compression/Deflate/FileCompressionLevelExample.vb ✅Succeeded View
samples/snippets/visualbasic/System.IO.Compression/Deflate/FileCompressionModeExample.vb ✅Succeeded View
samples/snippets/visualbasic/System.IO.Compression/Deflate/MemoryWriteReadExample.vb ✅Succeeded View
samples/snippets/visualbasic/VS_Snippets_CLR/IO.Compression.Deflate1/VB/deflatetest.vb ✅Succeeded
samples/snippets/visualbasic/VS_Snippets_CLR_System/system.io.compression.deflatestream/vb/program1.vb ✅Succeeded
samples/snippets/visualbasic/VS_Snippets_CLR_System/system.io.compression.deflatestream/vb/program2.vb ✅Succeeded
samples/snippets/visualbasic/VS_Snippets_CLR_System/system.io.compression.deflatestream/vb/program3.vb ✅Succeeded
xml/System.IO.Compression/DeflateStream.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop carlossanlop merged commit c084bd5 into dotnet:main Oct 5, 2021
@carlossanlop carlossanlop deleted the DeflateExamples branch October 5, 2021 16:20
@carlossanlop carlossanlop mentioned this pull request Oct 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gewarren gewarren gewarren approved these changes

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

@jozkee jozkee Awaiting requested review from jozkee

Assignees

@carlossanlop carlossanlop

Labels

area-System.IO.Compression

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@carlossanlop @opbld32 @opbld33 @opbld30 @opbld31 @gewarren