-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Replace FB issue tagging mentionees with dotnet teams #7614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace FB issue tagging mentionees with dotnet teams #7614
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Docs Build status updates of commit c7ced3b: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
carlossanlop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments, @eiriktsarpalis .
.github/fabricbot.json
Outdated
| "tarekgh", | ||
| "dotnet/area-system-text-encoding" | ||
| "dotnet/area-system-text-encoding", | ||
| "tarekgh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to keep Tarek here and below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tarek can be removed here; they're a member of the team.
.github/fabricbot.json
Outdated
| "vcsjones", | ||
| "krwq", | ||
| "GrabYourPitchForks" | ||
| "krwq" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mea to keep krwq?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krwq has remained subscribed to those notifications, so it was intentional. However, to make this more straightforward, I went ahead and added them to the dotnet/area-system-security team, so we can remove them from here.
.github/fabricbot.json
Outdated
| "vcsjones", | ||
| "krwq", | ||
| "GrabYourPitchForks" | ||
| "krwq" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krwq has remained subscribed to those notifications, so it was intentional. However, to make this more straightforward, I went ahead and added them to the dotnet/area-system-security team, so we can remove them from here.
.github/fabricbot.json
Outdated
| "tarekgh", | ||
| "dotnet/area-system-text-encoding" | ||
| "dotnet/area-system-text-encoding", | ||
| "tarekgh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tarek can be removed here; they're a member of the team.
.github/fabricbot.json
Outdated
| "tarekgh", | ||
| "dotnet/area-system-text-encodings-web" | ||
| "dotnet/area-system-text-encodings-web", | ||
| "tarekgh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added Tarek to this team so we can remove his explicit inclusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW we might want to make similar changes in the dotnet/runtime FB configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll spin up a PR over there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: dotnet/runtime#64199
|
Docs Build status updates of commit de70daf: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Updates FB issue tagging so that @dotnet teams are tagged instead of individual github handles, making it more consistent with issue tagging in dotnet/runtime.