Skip to content

Conversation

@eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Jan 20, 2022

Updates FB issue tagging so that @dotnet teams are tagged instead of individual github handles, making it more consistent with issue tagging in dotnet/runtime.

@eiriktsarpalis eiriktsarpalis requested a review from a team as a code owner January 20, 2022 18:32
@ghost
Copy link

ghost commented Jan 20, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@eiriktsarpalis eiriktsarpalis added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Jan 20, 2022
@eiriktsarpalis eiriktsarpalis self-assigned this Jan 20, 2022
@opbld34
Copy link

opbld34 commented Jan 20, 2022

Docs Build status updates of commit c7ced3b:

✅ Validation status: passed

File Status Preview URL Details
.github/fabricbot.json ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, @eiriktsarpalis .

"tarekgh",
"dotnet/area-system-text-encoding"
"dotnet/area-system-text-encoding",
"tarekgh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to keep Tarek here and below?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tarek can be removed here; they're a member of the team.

"vcsjones",
"krwq",
"GrabYourPitchForks"
"krwq"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mea to keep krwq?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krwq has remained subscribed to those notifications, so it was intentional. However, to make this more straightforward, I went ahead and added them to the dotnet/area-system-security team, so we can remove them from here.

"vcsjones",
"krwq",
"GrabYourPitchForks"
"krwq"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krwq has remained subscribed to those notifications, so it was intentional. However, to make this more straightforward, I went ahead and added them to the dotnet/area-system-security team, so we can remove them from here.

"tarekgh",
"dotnet/area-system-text-encoding"
"dotnet/area-system-text-encoding",
"tarekgh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tarek can be removed here; they're a member of the team.

"tarekgh",
"dotnet/area-system-text-encodings-web"
"dotnet/area-system-text-encodings-web",
"tarekgh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added Tarek to this team so we can remove his explicit inclusion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW we might want to make similar changes in the dotnet/runtime FB configs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll spin up a PR over there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@opbld30
Copy link

opbld30 commented Jan 22, 2022

Docs Build status updates of commit de70daf:

✅ Validation status: passed

File Status Preview URL Details
.github/fabricbot.json ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@jeffhandley jeffhandley merged commit e8fc5c9 into dotnet:main Jan 22, 2022
@eiriktsarpalis eiriktsarpalis deleted the fb-dotnet-team-mentionees branch January 24, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants