-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update Math.xml #8107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Math.xml #8107
Conversation
Per the explanation for each quadrant and boundary, the returned value cannot equal to -π in any case. (it's -π < θ , not -π <= θ , in quadrant dotnet#2 )
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Docs Build status updates of commit bee4cab: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
dakersnar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @tannergooding this could use a second review to confirm this is an accurate correction.
|
Closing this PR based on area owner feedback. Feel free to reopen if this was a mistake. |
|
This cannot be closed, as the problem is not whether it shall be ">=" or ">" but that the statements in the document are contradictory in that: the overview statement in the document says one thing while the case-by-case statement in the document says another. |
|
Ahh, understood. It sounds like the case-by-case statements need to be updated instead, is that correct? |
|
Learn Build status updates of commit bee4cab: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Yes. The other docs should be updated instead to correctly annotate the scenarios where |
…roductory statement. For atan2, the overview statement used to contradict the case-by-case statement. Now update the case-by-case statement, and simply remove the redundant part in the overview statement to avoid any inconsistency.
|
Learn Build status updates of commit 81aa056: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
xml/System/Math.xml
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
Learn Build status updates of commit 43b7613: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Per the explanation for each quadrant and boundary, the returned value cannot equal to -π in any case. (it's -π < θ , not -π <= θ , in quadrant 2 )
Preview link.