Skip to content

Conversation

@wangyoutian
Copy link
Contributor

@wangyoutian wangyoutian commented May 26, 2022

Per the explanation for each quadrant and boundary, the returned value cannot equal to -π in any case. (it's -π < θ , not -π <= θ , in quadrant 2 )

Preview link.

Per the explanation for each quadrant and boundary, the returned value cannot equal to -π in any case. (it's -π < θ , not  -π  <= θ , in quadrant dotnet#2 )
@wangyoutian wangyoutian requested a review from a team as a code owner May 26, 2022 09:12
@ghost ghost added the area-System.Runtime label May 26, 2022
@opbld34

This comment was marked as outdated.

@opbld30

This comment was marked as outdated.

@opbld30
Copy link

opbld30 commented May 26, 2022

Docs Build status updates of commit bee4cab:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Math.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@dakersnar dakersnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @tannergooding this could use a second review to confirm this is an accurate correction.

@dakersnar
Copy link
Contributor

Closing this PR based on area owner feedback. Feel free to reopen if this was a mistake.

@dakersnar dakersnar closed this Oct 18, 2022
@wangyoutian
Copy link
Contributor Author

This cannot be closed, as the problem is not whether it shall be ">=" or ">" but that the statements in the document are contradictory in that: the overview statement in the document says one thing while the case-by-case statement in the document says another.

@dakersnar
Copy link
Contributor

Ahh, understood. It sounds like the case-by-case statements need to be updated instead, is that correct?

@dakersnar dakersnar reopened this Oct 24, 2022
@opbld32
Copy link

opbld32 commented Oct 24, 2022

Learn Build status updates of commit bee4cab:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Math.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@tannergooding
Copy link
Member

Ahh, understood. It sounds like the case-by-case statements need to be updated instead, is that correct?

Yes. The other docs should be updated instead to correctly annotate the scenarios where -Pi can be returned.

…roductory statement.

For atan2, the overview statement used to contradict the case-by-case statement.  Now update the case-by-case statement, and simply remove the redundant part in the overview statement to avoid any inconsistency.
@opbld31
Copy link

opbld31 commented Oct 25, 2022

Learn Build status updates of commit 81aa056:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
xml/System/Math.xml ❌Error Details

  • Line 0, Column 0: [Error: ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...

xml/System/Math.xml

  • Line 0, Column 0: [Error: ECMA2Yaml_InternalError]
Intenal Several Error: System.Xml.XmlException: Reference to undeclared entity 'le'. Line 1031, position 75.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.HandleGeneralEntityReference(String name, Boolean isInAttributeValue, Boolean pushFakeEntityIfNullResolver, Int32 entityStartLinePos)
   at System.Xml.XmlTextReaderImpl.HandleEntityReference(Boolean isInAttributeValue, EntityExpandType expandType, Int32& charRefEndPos)
   at System.Xml.XmlTextReaderImpl.ParseText(Int32& startPos, Int32& endPos, Int32& outOrChars)
   at System.Xml.XmlTextReaderImpl.FinishPartialValue()
   at System.Xml.XmlTextReaderImpl.get_Value()
   at System.Xml.Linq.XContainer.ContentReader.ReadContentFrom(XContainer rootContainer, XmlReader r)
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld34
Copy link

opbld34 commented Oct 25, 2022

Learn Build status updates of commit 43b7613:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Math.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@dakersnar dakersnar merged commit 9e898fe into dotnet:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants