Update centos7 rpmpkg to use ruby 2.5#610
Conversation
dougbu
left a comment
There was a problem hiding this comment.
I don't know whether they're better nor whether all remain compatible w/ CentOS 7 but rh-ruby26*, rh-ruby27*, and rh-ruby30 packages are available.
mthalman
left a comment
There was a problem hiding this comment.
Can you return the Dockerfile back to its original format of including multiple commands in one RUN instruction?
- It's easier to read, especially when installing multiple packages.
- It's more efficient for image size. Each instruction causes the file modifications to be written to a separate layer. So if you execute
yum clean allin its own instruction, you end up having the files cleaned in the final container but all the files that were deleted still exist in the prior layers of the image and lead to unnecessary image bloat. You can read up more on Dockerfile best practices at https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run.
|
@mthalman I separated it out to try to find which install command was failing:
does |
If you're still working on debugging the Dockerfile, it would be better to mark this as a draft PR. In addition, it would be better to install Docker Desktop on your local machine and build the Dockerfile locally to diagnose issues.
I don't have much experience in this area. Looking at the other Dockerfiles in this repo that use gem, I see they just install |
|
Ok, should be working now |
Attempt to update the centos7 image to fix dotnet/aspnetcore#37406.