Rewrite Dockerfile for arm32 Linux samples#1006
Merged
Merged
Conversation
MichaelSimons
approved these changes
Mar 21, 2019
MichaelSimons
pushed a commit
to MichaelSimons/dotnet-docker
that referenced
this pull request
Mar 28, 2019
The samples build is failing for arm32 Linux leg because the build agents have an architecture of aarch64 and the multi-arch manifest description doesn't have a matching architecture for the 2.2 SDK and runtime images that we reference. To fix this, we eventually want to make use of the --platform option on the Docker CLI to explicitly set what platform we want to get but that's only available in experimental mode. To workaround this, we are going to modify the Dockerfile dynamically so it uses the platform-specific tag for the image instead of the 2.2 flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The samples build is failing for arm32 Linux leg because the build agents have an architecture of aarch64 and the multi-arch manifest description doesn't have a matching architecture for the 2.2 SDK and runtime images that we reference. To fix this, we eventually want to make use of the
--platformoption on the Docker CLI to explicitly set what platform we want to get but that's only available in experimental mode. To workaround this, we are going to modify the Dockerfile dynamically so it uses the platform-specific tag for the image instead of the 2.2 flag.