Skip to content

[main] Update dependencies from dotnet/arcade#2158

Merged
dotnet-maestro[bot] merged 4 commits intomainfrom
darc-main-0cdd8e98-9df1-485b-8d77-defcf11c9582
Oct 24, 2023
Merged

[main] Update dependencies from dotnet/arcade#2158
dotnet-maestro[bot] merged 4 commits intomainfrom
darc-main-0cdd8e98-9df1-485b-8d77-defcf11c9582

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 9, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: f607b9f2-509c-4318-eb57-08d8e4d5099b
  • Build: 20231018.2
  • Date Produced: October 19, 2023 4:42:16 AM UTC
  • Commit: 6a5ca678aef84f34a1fccc46f76623f41da56553
  • Branch: refs/heads/main
  • Updates to .NET SDKs:
    • Updates sdk.version to 8.0.100-rtm.23506.1
    • Updates tools.dotnet to 8.0.100-rtm.23506.1

@RussKie
Copy link
Copy Markdown
Contributor

RussKie commented Oct 12, 2023

test\UnitTests\UnitTests.csproj(0,0): error NU1202: (NETCORE_ENGINEERING_TELEMETRY=Restore) Package xunit.runner.visualstudio 2.5.1 is not compatible with net452 (.NETFramework,Version=v4.5.2). Package xunit.runner.visualstudio 2.5.1 supports:
  - net462 (.NETFramework,Version=v4.6.2)
  - net6.0 (.NETCoreApp,Version=v6.0)

This looks related to dotnet/arcade#14036. @ViktorHofer any thoughts on how to fix this?

@RussKie
Copy link
Copy Markdown
Contributor

RussKie commented Oct 12, 2023

@ajcvickers can someone from your team look into this too?

@ViktorHofer
Copy link
Copy Markdown
Member

ViktorHofer commented Oct 12, 2023

This looks related to dotnet/arcade#14036. @ViktorHofer any thoughts on how to fix this?

xunit.runner.visualstudio/2.5.1 doesn't support EOL runtimes anymore: https://www.nuget.org/packages/xunit.runner.visualstudio/2.5.1#dependencies-body-tab. .NET Framework 4.5.2 has been out of support for years. Can you update that TFM to the minimum in support version which is net462?

@mgravell
Copy link
Copy Markdown
Contributor

mgravell commented Oct 18, 2023

to help unblock this, I have proposed (since I was on build-ops): #2162 - let's see how happy/unhappy CI is with that - then we can combine these?

…008.1

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23508.1
…010.4

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23510.4
@javiercn javiercn force-pushed the darc-main-0cdd8e98-9df1-485b-8d77-defcf11c9582 branch from 2767c4c to e694385 Compare October 20, 2023 18:09
javiercn and others added 2 commits October 20, 2023 23:59
…018.2

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23518.2
@amcasey
Copy link
Copy Markdown
Member

amcasey commented Oct 23, 2023

Test failure looks like a change in the formatting of test assert failure messages

                                  ↓ (pos 22)
Expected: ···"sert.Equal() Failure\r\nExpected: 5\r\nActual"···
Actual:   ···"sert.Equal() Failure: Values differ\r\nExpe"···
                                  ↑ (pos 22)

@ErikEJ
Copy link
Copy Markdown
Contributor

ErikEJ commented Oct 23, 2023

@amcasey I just did a PR attempt to fix this: #2163

@amcasey
Copy link
Copy Markdown
Member

amcasey commented Oct 24, 2023

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-maestro dotnet-maestro bot merged commit 1b944f1 into main Oct 24, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-0cdd8e98-9df1-485b-8d77-defcf11c9582 branch October 24, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants