Primary Contructor Causes analyzer misfire

[dukedagmor]

#26795
Doesnt work with a primary constructor

this has the correct analyzers:

public class MyDbContext : DbContext
{
    public MyDbContext(DbContextOptions<MyDbContext> options ) : base(options) { }

    public DbSet<UserSettings> UserSettings { get; set; }
}

vs
this doesn't:

public class MyDbContext(DbContextOptions<MyDbContext> options) : DbContext(options)
{
    public DbSet<UserSettings> UserSettings { get; set; }
}

IDE: Microsoft Visual Studio Enterprise 2022 (64-bit) - Preview Version 17.12.0 Preview 5.0

[roji]

I'm not sure what you mean by "has the correct analyzers"; the code you posted above with the primary constructor doesn't produce a warning for me, using the following console program (this is with dotnet sdk 8.0.403):

Console.WriteLine("Hello world");

public class MyDbContext(DbContextOptions<MyDbContext> options) : DbContext(options)
{
    public DbSet<UserSettings> UserSettings { get; set; }
}

public class UserSettings
{
    public int Id { get; set; }
}

Can you please put together a similar self-contained, runnable console program that shows the problem, and post exactly which dotnet SDK you're using (as well as your csproj)?

[dukedagmor]

I still get the error, even in a tiny contained sample:

using Microsoft.EntityFrameworkCore;
using System.Collections.Generic;

Console.WriteLine("Hello world");

public class MyDbContext(DbContextOptions<MyDbContext> options) : DbContext(options)
{
    public DbSet<UserSettings> UserSettings { get; set; }
}

public class UserSettings
{
    public int Id { get; set; }
}

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net8.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.EntityFrameworkCore" Version="9.0.0" />
  </ItemGroup>

</Project>

[roji]

First, can you please test again with the released VS 2022 17.12 (you indicated above that you're using a preview).

If you still see the problem, can you confirm whether you can see the warning when building on the commandline (dotnet build /t:Rebuild)? And post the output of dotnet --list-sdks?

[dukedagmor]

I added the logVersion21.json,version=2.1 flag to my .csproj
I'll attacht that file: logVersion21.json

the most relevant portion is I believe the following:

    {
      "results": [
        {
          "ruleId": "CS8618",
          "ruleIndex": 324,
          "level": "warning",
          "message": {
            "text": "Non-nullable property 'UserSettings' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable."
          },
          "suppressions": [
            {
              "kind": "inSource",
              "properties": {
                "suppressionType": "DiagnosticSuppressor { Suppression Id: EFSPR1001, Suppression Justification: DbSet properties on DbContext subclasses are automatically populated by the DbContext constructor. }"
              }
            }
          ],
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "file:///C:/Repo/Demos/MyContext/Program.cs"
                },
                "region": {
                  "startLine": 8,
                  "startColumn": 32,
                  "endLine": 8,
                  "endColumn": 44
                }
              }
            }
          ],
          "relatedLocations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "file:///C:/Repo/Demos/MyContext/Program.cs"
                },
                "region": {
                  "startLine": 8,
                  "startColumn": 32,
                  "endLine": 8,
                  "endColumn": 44
                }
              }
            }
          ],
          "properties": {
            "warningLevel": 1
          }
        },

my console run

Visual studio is atill showing the error, both in 17.12.0 and 17.13.0 preview 1.0

[ajcvickers]

@roji This repros for me with a fresh install of VS 17.12.2 Community.

No warning when building on the command line.

C:\Users\ajcvi>dotnet --info
.NET SDK:
 Version:           9.0.100
 Commit:            59db016f11
 Workload version:  9.0.100-manifests.4a280210
 MSBuild version:   17.12.7+5b8665660

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.19045
 OS Platform: Windows
 RID:         win-x64
 Base Path:   C:\Program Files\dotnet\sdk\9.0.100\

.NET workloads installed:
There are no installed workloads to display.
Configured to use loose manifests when installing new manifests.

Host:
  Version:      9.0.0
  Architecture: x64
  Commit:       9d5a6a9aa4

.NET SDKs installed:
  8.0.404 [C:\Program Files\dotnet\sdk]
  9.0.100-rc.1.24452.12 [C:\Program Files\dotnet\sdk]
  9.0.100 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 8.0.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 9.0.0-rc.1.24452.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 9.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 8.0.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 9.0.0-rc.1.24431.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 9.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 8.0.11 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 9.0.0-rc.1.24452.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 9.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
  x86   [C:\Program Files (x86)\dotnet]
    registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Environment variables:
  Not set

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

[roji]

Thanks @ajcvickers, I'll take another look.

[roji]

I still can't reproduce this warning - not on the command-line in any case. I've tried compiling the following minimal sample with dotnet SDKs 9.0.300, 10.0.100-preview.5.25277.114 and 8.0.409:

var options = new DbContextOptionsBuilder<BlogContext>()
    .UseSqlServer("Server=localhost;Database=test;User=SA;Password=Abcd5678;Connect Timeout=60;ConnectRetryCount=0;Encrypt=false")
    .Options;

await using var context = new BlogContext(options);
await context.Database.EnsureDeletedAsync();
await context.Database.EnsureCreatedAsync();

public class BlogContext(DbContextOptions<BlogContext> options) : DbContext(options)
{
    public DbSet<Blog> Blogs { get; set; }
}

public class Blog
{
    public int Id { get; set; }
    public string Name { get; set; }
}

This generates a warning for the Name property not being initialized (which shows NRTs are enabled etc.), but not for the Blogs property not being initialized (since we have a suppressor for that).

I also tried this on Visual Studio 2022 17.14.5 - same results.

I'll go ahead and close this now as a probably temporary issue somewhere that has been resolved since it was opened. However, @dukedagmor and others, if you're still running into this and are using recent versions of Visual Studio/dotnet SDK, please post back here with the relevant information and I'll take another look.