`ExecuteUpdateAsync` triggers `IL2037: No members were resolved for ...`

[austindrenski]

Bug description

Hi folks, I'm seeing a new trimmer warning for IL2037 while migrating to .NET 10 which looks like it might be caused by a typo:

ILLink : error IL2037: Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ExecuteUpdateAsync<TSource>(IQueryable<TSource>, Action<UpdateSettersBuilder<TSource>>, CancellationToken): No members were resolved for 'ExecuteUpdate``1(System.Linq.IQueryable{``1},System.Collections.Generic.IReadOnlyList{ITuple})' on type 'Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions'.

which appears to be complaining that this signature:

ExecuteUpdate``1(System.Linq.IQueryable{``1},System.Collections.Generic.IReadOnlyList{ITuple})

doesn't resolve to:

private static int ExecuteUpdate<TSource>(this IQueryable<TSource> source, [NotParameterized] IReadOnlyList<ITuple> setters)
    => throw new UnreachableException("Can't call this overload directly");

I'm filing this ticket without a repro (for now) because it looks like this might just be caused by a backtick typo—i.e., IQueryable{``1} instead of IQueryable{``0}—and wanted to see if anyone familiar with how the linker/trimmer implements DynamicDependency might be able to confirm/reject my guess before I sink time into a repro.

(I know, I know: "user opens ticket without repro and thinks they're justified because of XYZ" is tantamount to a capital crime, but humor me?)

References

• https://github.com/dotnet/efcore/blob/v10.0.0/src/EFCore/Extensions/EntityFrameworkQueryableExtensions.cs#L3398-L3400
• https://github.com/dotnet/runtime/blob/v10.0.0/src/tools/illink/src/linker/Linker/DocumentationSignatureGenerator.PartVisitor.cs#L89-L90
• https://github.com/dotnet/runtime/blob/v10.0.0/src/tools/illink/src/linker/Linker/DocumentationSignatureGenerator.PartVisitor.cs#L60-L82
• https://github.com/dotnet/runtime/blob/v10.0.0/src/tools/illink/src/linker/Linker/DocumentationSignatureGenerator.PartVisitor.cs#L141-L203

Your code

_(I know, I know: "user opens ticket without repro and thinks they're justified because of XYZ" is tantamount to a capital crime, but humor me?)_

Stack traces

ILLink : error IL2037: Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ExecuteUpdateAsync<TSource>(IQueryable<TSource>, Action<UpdateSettersBuilder<TSource>>, CancellationToken): No members were resolved for 'ExecuteUpdate``1(System.Linq.IQueryable{``1},System.Collections.Generic.IReadOnlyList{ITuple})' on type 'Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions'.

Verbose output

EF Core version

10.0.0

Database provider

No response

Target framework

.NET 10.0

Operating system

No response

IDE

No response

[roji]

Hey @austindrenski 👋

Yep, you're right - the [DynamicDependency] there is mangled. I've submitted #37194 to fix this.

However, as EF isn't currently actually trimming/AOT compatible, I'm not sure we'll be backporting this... I'm assuming this isn't blocking given all the other trimming/AOT warnings that EF currently causes?

[austindrenski]

Howdy! 👋

I'm assuming this isn't blocking given all the other trimming/AOT warnings that EF currently causes?

Well... It's not blocking because I've slapped this into my affected projects:

<PropertyGroup>
  <!-- TODO: https://github.com/dotnet/efcore/issues/37192 -->
  <WarningsNotAsErrors>$(WarningsNotAsErrors);IL2037</WarningsNotAsErrors>
</PropertyGroup>

// TODO: https://github.com/dotnet/efcore/issues/37192
[DynamicDependency("ExecuteUpdate``1(System.Linq.IQueryable{``0},System.Collections.Generic.IReadOnlyList{System.Runtime.CompilerServices.ITuple})", typeof(EntityFrameworkQueryableExtensions))]
async ValueTask SomeMethodThatCallsExecuteUpdateAsync(...) { ... }

So that's not pretty, but it seems to work well enough so far.

However, as EF isn't currently actually trimming/AOT compatible [...] given all the other trimming/AOT warnings that EF currently causes?

About that... 🙃

Long story short, the projects that surfaced this issue are opted into some trimming, but they also suppress just about all of the warnings that Roslyn tries to tell us about:

<PropertyGroup>
  <!-- TODO: needs review -->
  <!--<PublishAot>true</PublishAot>-->
  <IsAotCompatible>false</IsAotCompatible>
  <!-- TODO: EF Core AOT is still highly experimental, see: https://learn.microsoft.com/ef/core/performance/nativeaot-and-precompiled-queries -->
  <EnableAotAnalyzer>false</EnableAotAnalyzer>
  <EnableCompressionInSingleFile>true</EnableCompressionInSingleFile>
  <PublishSingleFile>true</PublishSingleFile>
  <PublishTrimmed>true</PublishTrimmed>
  <RuntimeIdentifier>linux-x64</RuntimeIdentifier>
  <!-- TODO: .NET 7 default is `false` -->
  <SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings>
  <!-- TODO: .NET 8 default is `full` -->
  <TrimMode>partial</TrimMode>
</PropertyGroup>

So, this^ block of config isn't something I'd expect anyone from the efcore team to endorse for production workloads, but what caught me off-guard was seeing IL2037 at all, given that I have both EnableAotAnalyzer=false and SuppressTrimAnalysisWarnings=true.

So, if I were going to make the argument for backporting, its not so much that efcore owes anyone robust trimming/aot support, but rather that this is (IMO) in the same category as a borked reflection field lookup. Even if its not part of an endorsed public API, its still broken from the perspective of the tooling (i.e., given that its raising a warning that seems to fall outside the category of "normal" trim analysis warnings).

[roji]

Sure, I understand. We'll discuss this and see about backporting.

[mvoxland]

Please backport! My .NET 10 WebAssembly and Maui projects are both getting this error, and I don't want to keep them downgraded to 9.

[rbakhshi]

Our Android MAUI app used to be trimmed in net8.0 (below is from the logs) but after upgrading to net10 it is now failing in trimming.

[85/241] Microsoft.EntityFrameworkCore.dll -> Microsoft.EntityFrameworkCore.dll.so
[47/241] Microsoft.EntityFrameworkCore.Abstractions.dll -> Microsoft.EntityFrameworkCore.Abstractions.dll.so
[48/241] Microsoft.EntityFrameworkCore.Relational.dll -> Microsoft.EntityFrameworkCore.Relational.dll.so
[49/241] Microsoft.EntityFrameworkCore.Sqlite.dll -> Microsoft.EntityFrameworkCore.Sqlite.dll.so