11.0 API Reviews

[AndriySvyryd]

As a team, we periodically review changes made to the public API. This issue tracks follow-up items that come out of those reviews for the 11.0 release.

Feb 24

• @roji Take a look at the AOT suppression on EntityFrameworkQueryableExtensions
  • @AndriySvyryd not sure what this referred to - the previous AOT-related suppression was removed in Stop using MakeGenericMethod in our custom LINQ operators #37360... Any idea?

Mar 18

• @roji Move FullTextSearchResult to the .Query namespace
• @roji Remove HasFullTextCatalog, HasFullTextChangeTracking, HasFullTextKeyIndex, HasFullTextLanguage extension methods (other than the ones defined for IConventionIndexBuilder)
• @roji Remove name from the parameter names for the above and the corresponding CanSet* methods

Mar 23

• @roji SqlServerFullTextIndexBuilder and SqlServerFullTextIndexBuilder<>:
  • HasKeyIndex -> UseKeyIndex
  • HasLanguage -> UseLanguage
  • OnCatalog -> UseCatalog
  • WithChangeTracking -> HasChangeTracking
  • Remove name from the parameter names for the above
• @roji SqlServerVectorIndexBuilder and SqlServerVectorIndexBuilder<>:
  • UseMetric -> HasMetric
  • UseType -> HasType
• @roji Validate that no unsupported configuration was performed using the Metadata API
  • @AndriySvyryd do you remember specifics?
    • This is about index options not supported on full text or vector indices. We don't want them to be silently ignored
• @roji Move columnSelector parameter right and make optional to collapse overloads of ContainsTable and FreeTextTable in SqlServerQueryableExtensions
• @AndriySvyryd Rename CosmosDbContextOptionsBuilder.BulkExecutionEnabled to BulkExecutionAllowed
• @AndriySvyryd Rename ModelSnapshot.LatestMigrationId to LastMigrationId

Apr 20

• @AndriySvyryd Consider renaming ProviderMismatchEventData.CompiledProviderName
• @AndriySvyryd Rename JsonPath and JsonPathSegment to StructuredJsonPath and StructuredJsonPathSegment and move the latter to .Metadata
  • Rename JsonPath.Ordinals to Indices

[JoasE]

@AndriySvyryd Just stumbled upon this

@AndriySvyryd Rename CosmosDbContextOptionsBuilder.BulkExecutionEnabled to BulkExecutionAllowed

FYI: Are you doing this because the option is called BulkExecutionAllowed in the Cosmos Sdk? I personally find that that to be a bit misleading in the sdk, as every write except a TransactionalBatch will be bulk, and there is no (other) way to opt out. I specifically opted for Enabled since every non-batched write will be executed using bulk and we have a default throwing warning for batched writes (only for AutoTransactionBehavior.WhenNeeded). Meaning savechanges will either throw or execute using bulk. (except when specifically set to AutoTransactionBehavior.Always). Just wanted to add some context here, no need to respond if you have already taken this into account

[AndriySvyryd]

@JoasE Yes, we discussed that. Eventually we want to allow users to pass in CosmosClientOptions and obsolete our wrappers that would become redundant, so we decided to align the naming (even if the actual behavior is a bit different when used with EF as you described).