Query filters with primary constructor parameters fail in 10.0.6

[matburton]

Bug description

Code which make use of a query filter defined on the model fail when the context is used throwing a SqlException with message:

Incorrect syntax near '<'.
Must declare the scalar variable "@ef_filter__".

I'm reproducing this with version 10.0.6 of Microsoft.EntityFrameworkCore.SqlServer.
I cannot reproduce with version 10.0.5.

Your code

Here's a cut down example:


sealed class DatabaseContext(string connectionString, Guid tenantUuid)
    :
    DbContext(new DbContextOptionsBuilder<DatabaseContext>()
                 .UseSqlServer(connectionString)
                 .EnableDetailedErrors()
                 .Options)
{
    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
        base.OnModelCreating(modelBuilder);

        modelBuilder.Entity<PersonBinding>()
                    .HasQueryFilter(b => b.TenantUuid == tenantUuid);
    }

    public DbSet<PersonBinding> People => Set<PersonBinding>();
}


Then this throws:

using var db = new DatabaseContext(databaseConnectionString, tenantUuid);

var people = db.People.Where(b => b.LikesEntityFramework).ToArray();

Stack traces

at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
at Microsoft.Data.SqlClient.Connection.SqlConnectionInternal.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose)
at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
at Microsoft.Data.SqlClient.SqlDataReader.TryConsumeMetaData()
at Microsoft.Data.SqlClient.SqlDataReader.get_MetaData()
at Microsoft.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString, Boolean isInternal, Boolean forDescribeParameterEncryption, Boolean shouldCacheForAlwaysEncrypted)
at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean isAsync, Int32 timeout, Task& task, Boolean asyncWrite, Boolean isRetry, SqlDataReader ds, Boolean describeParameterEncryptionRequest)
at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, TaskCompletionSource`1 completion, Int32 timeout, Task& executeTask, Boolean& usedCache, Boolean asyncWrite, Boolean isRetry, String method)
at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method)
at Microsoft.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior)
at Microsoft.Data.SqlClient.SqlCommand.ExecuteDbDataReader(CommandBehavior behavior)
at Microsoft.EntityFrameworkCore.Storage.RelationalCommand.ExecuteReader(RelationalCommandParameterObject parameterObject)
at Microsoft.EntityFrameworkCore.Query.Internal.SingleQueryingEnumerable`1.Enumerator.InitializeReader(Enumerator enumerator)
at Microsoft.EntityFrameworkCore.Query.Internal.SingleQueryingEnumerable`1.Enumerator.<>c.<MoveNext>b__21_0(DbContext _, Enumerator enumerator)
at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerExecutionStrategy.Execute[TState,TResult](TState state, Func`3 operation, Func`3 verifySucceeded)
at Microsoft.EntityFrameworkCore.Query.Internal.SingleQueryingEnumerable`1.Enumerator.MoveNext()
at System.Linq.Enumerable.<ToArray>g__EnumerableToArray|324_0[TSource](IEnumerable`1 source)
at ...

Verbose output

EF Core version

10.0.6

Database provider

No response

Target framework

.NET 10

Operating system

Linux

IDE

Rider

[roji]

AI Triage

The below is an AI-generated analysis and may contain inaccuracies.

Summary

Confirmed bug. This is a regression in 10.0.6, introduced by the fix for #37465 (PR #37805). The query works correctly in 10.0.5.

Root Cause

When a query filter references a primary constructor parameter (e.g. tenantUuid), the C# compiler stores it as a backing field with a compiler-generated name like <tenantUuid>P. The query filter parameter naming code in ExpressionTreeFuncletizer (line 2147) uses the raw Member.Name to construct the parameter name, producing ef_filter__<tenantUuid>P.

Before #37805, the old code stripped angle brackets via parameterName.LastIndexOf('>'), turning this into P. After #37805, that stripping was replaced with SanitizeCompilerGeneratedName, but only in the regular parameter evaluation path (MemberExpression field/property cases in EvaluateCore). The query filter naming path at line 2147 was not updated and still uses the raw Member.Name containing angle brackets. There is also no general safety check for invalid characters in the parameter name on release/10.0 (such a check was added later on main).

The result is that SQL containing @ef_filter__<tenantUuid>P is sent to SQL Server, which fails because < is not valid in parameter names.

Regression

Version	Result
10.0.5	✅ Works (@P)
10.0.6	❌ Fails (@ef_filter__<tenantUuid>P)

Related Issues

• #37465 — The fix ([release/10.0] Fix invalid SQL parameter names for switch/case pattern-matched variables #37805) that introduced this regression
• #37805 — The PR with the parameter name sanitization change

Minimal repro

using System.Linq;
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Logging;

var tenantUuid = Guid.NewGuid();

await using var context = new TestContext(
    Environment.GetEnvironmentVariable("Test__SqlServer__DefaultConnection")!, tenantUuid);
await context.Database.EnsureDeletedAsync();
await context.Database.EnsureCreatedAsync();

var people = context.People.Where(b => b.Name != null).ToArray();

public sealed class TestContext(string connectionString, Guid tenantUuid) : DbContext
{
    public DbSet<Person> People => Set<Person>();

    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        => optionsBuilder
            .UseSqlServer(connectionString)
            .LogTo(Console.WriteLine, LogLevel.Information)
            .EnableSensitiveDataLogging();

    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
        modelBuilder.Entity<Person>()
            .HasQueryFilter(b => b.TenantUuid == tenantUuid);
    }
}

public class Person
{
    public int Id { get; set; }
    public string? Name { get; set; }
    public Guid TenantUuid { get; set; }
}

Project file (tested with Microsoft.EntityFrameworkCore.SqlServer 10.0.6):

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net10.0</TargetFramework>
    <Nullable>enable</Nullable>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="10.0.6" />
  </ItemGroup>
</Project>