SQLite Query: Translate Math.Max, Min & Round#10533
Merged
bricelam merged 1 commit intodotnet:devfrom Dec 12, 2017
bricelam:math
Merged
SQLite Query: Translate Math.Max, Min & Round#10533bricelam merged 1 commit intodotnet:devfrom bricelam:math
bricelam merged 1 commit intodotnet:devfrom
bricelam:math
Conversation
Contributor
Author
|
(There was no direct translation of |
smitpatel
approved these changes
Dec 11, 2017
| { typeof(Math).GetMethod(nameof(Math.Round), new[]{ typeof(decimal), typeof(int) }), "round" } | ||
| }; | ||
|
|
||
| static SqliteMathTranslator() |
Contributor
There was a problem hiding this comment.
Add access-level modifier.
Contributor
Author
There was a problem hiding this comment.
Invalid syntax. This is a static constructor...
|
|
||
| private static void AddSupportedTranslation(Type declaringType, string clrMethodName, string sqlFunctionName) | ||
| { | ||
| var methodInfos = declaringType.GetTypeInfo().GetDeclaredMethods(clrMethodName); |
Contributor
Author
There was a problem hiding this comment.
(Less readable to me.)
| } | ||
|
|
||
| [ConditionalFact] | ||
| public virtual void Where_math_max() |
Contributor
There was a problem hiding this comment.
Can you add SQL Assertions in SqlServer? They would client eval but it would be still good to have it so that we know it actually does not translate fully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10526