[WIP] Basic support for non-nullable references#14983
Closed
roji wants to merge 2 commits intodotnet:masterfrom
Closed
[WIP] Basic support for non-nullable references#14983roji wants to merge 2 commits intodotnet:masterfrom
roji wants to merge 2 commits intodotnet:masterfrom
Conversation
|
Since the Milestone of the Roslyn PR you referenced is |
Member
Author
|
@vslee thanks for the comment. There's still a bit of work before this can get merged, but hopefully that will happen quite soon. |
Member
Author
|
Superceded by #15499 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This WIP PR adds first support for taking the new C# 8.0 non-nullable references into account in model building. This adds convention logic that interprets non-nullable references in the same way as
[Required]- for both regular and navigation properties.Some notes:
Reference_nullability_sets_is_nullable_correctly(NullAwareNonNullable)fails in VS2019 - this is a result of seeing a[Nullable]version from before NullableAttribute constructor parameter should be stored in a field roslyn#30143 (VS is somehow stuck behind, not using the latest Roslyn or something)? @bricelam we briefly discussed this, if you feel like taking a quick look to make sure I'm not crazy....