CosmosDb provider support for a current region option

[dimangulov]

CosmosDb provider doesn't support a configuration option for a current region

Fix #15007

Please check if the PR fulfills these requirements

• The code builds and tests pass (verified by our automated build checks)
• Commit messages follow this format

    Summary of the changes
    - Detail 1
    - Detail 2

    Fixes #bugnumber

• Tests for the changes have been added (for bug fixes / features)
• Code meets the expectations our engineering guidelines. https://github.com/aspnet/Home/wiki/Engineering-guidelines.

Please review the guidelines for CONTRIBUTING.md for more details.

[dnfclas]

All CLA requirements met.

[ajcvickers]

@dimangulov We looked at this in triage and the general idea seems fine. However, because "region" is optional, could we make setting it be a method on CosmosDbContextOptionsBuilder instead of a parameter that is passed to UseCosmos()? (We generally try to avoid adding too many parameters to UseProvider methods since it can quickly become unwieldy. )

[dimangulov]

I guess, it can be. I will prepare a new pull request.

…

On Fri, Mar 15, 2019, 22:28 Arthur Vickers ***@***.***> wrote: @dimangulov <https://github.com/dimangulov> We looked at this in triage and the general idea seems fine. However, because "region" is optional, could we make setting it be a method on CosmosDbContextOptionsBuilder instead of a parameter that is passed to UseCosmos()? (We generally try to avoid adding too many parameters to UseProvider methods since it can quickly become unwieldy. ) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15009 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGF5MW-KuznkCQkWeD4i7otnvUINew9nks5vXAJPgaJpZM4bs7tF> .

[dimangulov]

@ajcvickers Done. Does it look better now?

[ajcvickers]

Can you add at least one test that makes sure that the region gets set correctly? @AndriySvyryd can likely point you to the appropriate place.

[ajcvickers]

Need to copy _region onto the new object in the copy-constructor below.

[dimangulov]

This is done

[AndriySvyryd]

@dimangulov You can add a test in CosmosEndToEndTest that uses some invalid region and asserts that a "Current location is not a valid Azure region." exception is thrown.

[dimangulov]

Added 2 end to end and 2 unit tests, let me know if there is smth else missed

[AndriySvyryd]

Also rebase and squash the commits

[ajcvickers]

Thanks @dimangulov!

[dimangulov]

Thank you guys! It was pleasure for me work with you. Thanks for the experience! ср, 20 мар. 2019 г. в 23:39, Arthur Vickers <notifications@github.com>:

…

Thanks @dimangulov <https://github.com/dimangulov>! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15009 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGF5MYFbiYDhEVypt_xHWMKXnA__uMOUks5vYqp9gaJpZM4bs7tF> .