[release/3.0] Update dependencies from aspnet/Extensions by dotnet-maestro[bot] · Pull Request #18207 · dotnet/efcore

dotnet-maestro · 2019-10-03T16:25:22Z

This pull request updates the following dependencies

From https://github.com/aspnet/Extensions

Build: 20191004.7
Date Produced: 10/4/2019 11:01 PM
Commit: 1a34885e2800a7b387e006a12d72a5a19febf922
Branch: refs/heads/release/3.0
Updates:
- Microsoft.Extensions.DependencyInjection -> 3.0.1
- Microsoft.Extensions.Configuration.Json -> 3.0.1
- Microsoft.Extensions.Configuration.EnvironmentVariables -> 3.0.1
- Microsoft.Extensions.Configuration -> 3.0.1
- Microsoft.Extensions.Caching.Memory -> 3.0.1
- Microsoft.Extensions.HostFactoryResolver.Sources -> 3.0.1-servicing.19504.7
- Microsoft.Extensions.Logging -> 3.0.1

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Microsoft.NETCore.App.Runtime.win-x64 -> 3.0.1 (parent: Microsoft.Extensions.Logging)
Microsoft.DotNet.PlatformAbstractions -> 3.0.1 (parent: Microsoft.Extensions.Logging)
Microsoft.Extensions.DependencyModel -> 3.0.1 (parent: Microsoft.Extensions.Logging)
Microsoft.NETCore.App.Ref -> 3.0.1 (parent: Microsoft.Extensions.Logging)
NETStandard.Library.Ref -> 2.1.0 (parent: Microsoft.Extensions.Logging)

…0191003.1 - Microsoft.Extensions.DependencyInjection - 3.0.1-servicing.19503.1 - Microsoft.Extensions.Configuration.Json - 3.0.1-servicing.19503.1 - Microsoft.Extensions.Configuration.EnvironmentVariables - 3.0.1-servicing.19503.1 - Microsoft.Extensions.Configuration - 3.0.1-servicing.19503.1 - Microsoft.Extensions.Caching.Memory - 3.0.1-servicing.19503.1 - Microsoft.Extensions.HostFactoryResolver.Sources - 3.0.1-servicing.19503.1 - Microsoft.Extensions.Logging - 3.0.1-servicing.19503.1 Dependency coherency updates - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.1 (parent: Microsoft.Extensions.Logging) - Microsoft.DotNet.PlatformAbstractions - 3.0.1 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.DependencyModel - 3.0.1 (parent: Microsoft.Extensions.Logging) - Microsoft.NETCore.App.Ref - 3.0.1 (parent: Microsoft.Extensions.Logging) - NETStandard.Library.Ref - 2.1.0 (parent: Microsoft.Extensions.Logging)

dotnet-maestro · 2019-10-03T16:30:24Z

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

✔️ Standard Merge Policies Succeeded - Successful checks: EntityFrameworkCore-ci, EntityFrameworkCore-ci (Build Linux), EntityFrameworkCore-ci (Build Windows), EntityFrameworkCore-ci (Build macOS)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…0191004.1 - Microsoft.Extensions.DependencyInjection - 3.0.1-servicing.19504.1 - Microsoft.Extensions.Configuration.Json - 3.0.1-servicing.19504.1 - Microsoft.Extensions.Configuration.EnvironmentVariables - 3.0.1-servicing.19504.1 - Microsoft.Extensions.Configuration - 3.0.1-servicing.19504.1 - Microsoft.Extensions.Caching.Memory - 3.0.1-servicing.19504.1 - Microsoft.Extensions.HostFactoryResolver.Sources - 3.0.1-servicing.19504.1 - Microsoft.Extensions.Logging - 3.0.1-servicing.19504.1 Dependency coherency updates - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0 (parent: Microsoft.Extensions.Logging) - Microsoft.DotNet.PlatformAbstractions - 3.0.0 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.DependencyModel - 3.0.0 (parent: Microsoft.Extensions.Logging) - Microsoft.NETCore.App.Ref - 3.0.0 (parent: Microsoft.Extensions.Logging) - NETStandard.Library.Ref - 2.1.0 (parent: Microsoft.Extensions.Logging) - System.Collections.Immutable - 1.6.0 (parent: Microsoft.NETCore.App.Runtime.win-x64) - System.ComponentModel.Annotations - 4.6.0 (parent: Microsoft.NETCore.App.Runtime.win-x64) - System.Diagnostics.DiagnosticSource - 4.6.0 (parent: Microsoft.NETCore.App.Runtime.win-x64)

dougbu · 2019-10-04T17:44:01Z

      <Sha>bedb348c4d93b6172967df6cdeea0272c81eb752</Sha>
    </Dependency>
-    <Dependency Name="Microsoft.DotNet.PlatformAbstractions" Version="3.0.1-servicing-19502-01" CoherentParentDependency="Microsoft.Extensions.Logging">
+    <Dependency Name="Microsoft.DotNet.PlatformAbstractions" Version="3.0.0" CoherentParentDependency="Microsoft.Extensions.Logging">


@wtgodbe why is the bot going back in time here?

Great question - @mmitche is this related to dotnet/core-setup#8425 or dotnet/core-setup#8426?

CC @dagood

I think this is because of the CoherentParentDependency on extensions and dotnet/extensions@40cae90

What this means I think is that when it goes to look up which platform abstractions to update to, there are two. There;s one that is available via the pinned ref assembly, and one available via Microsoft.NETCore.App.Runtime.win-x64.

We really want the second one, not the first.

Should we redo merge conflict resolution (if any) and prefer 3.0.1-servicing-19502-01 over 3.0.0? Is 3.0.0 correct for Microsoft.NETCore.App.Ref? Is 2.1.0 correct for NETStandard.Library.Ref?

NETStandard.Library.Ref is not pinned in Extensions. Should it be?

At a higher level, can the bot be improved to handle pinned dependencies better? Or, would we avoid these problems in the future if we pinned Microsoft.NETCore.App.Ref here too?

Ping @mmitche

dougbu · 2019-10-04T19:37:48Z

Wait for resolution of conversation here and any necessary changes before merging.

dotnet-maestro · 2019-10-04T19:40:22Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

✔️ Standard Merge Policies Succeeded - Successful checks: EntityFrameworkCore-ci, EntityFrameworkCore-ci (Build Linux), EntityFrameworkCore-ci (Build macOS), EntityFrameworkCore-ci (Build Windows)
❌ Standard Merge Policies There are reviews that have requested changes.

@mmitche

Move the pinned dependency on `Microsoft.Netcore.App` to the bottom of versions.details.xml to prevent it being picked for CoherentParentDependencies CC @mmitche @dougbu - we think this will fix dotnet/efcore#18207

dougbu

Until move to 3.0.0 versions has been resolved, don't merge

…0191004.7 - Microsoft.Extensions.DependencyInjection - 3.0.1 - Microsoft.Extensions.Configuration.Json - 3.0.1 - Microsoft.Extensions.Configuration.EnvironmentVariables - 3.0.1 - Microsoft.Extensions.Configuration - 3.0.1 - Microsoft.Extensions.Caching.Memory - 3.0.1 - Microsoft.Extensions.HostFactoryResolver.Sources - 3.0.1-servicing.19504.7 - Microsoft.Extensions.Logging - 3.0.1 Dependency coherency updates - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.1 (parent: Microsoft.Extensions.Logging) - Microsoft.DotNet.PlatformAbstractions - 3.0.1 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.DependencyModel - 3.0.1 (parent: Microsoft.Extensions.Logging) - Microsoft.NETCore.App.Ref - 3.0.1 (parent: Microsoft.Extensions.Logging) - NETStandard.Library.Ref - 2.1.0 (parent: Microsoft.Extensions.Logging)

dotnet-maestro Bot requested a review from dougbu as a code owner October 3, 2019 16:25

dougbu added the area-infrastructure label Oct 4, 2019

dougbu reviewed Oct 4, 2019

View reviewed changes

dougbu changed the title ~~[release/3.0] Update dependencies from aspnet/Extensions~~ [do not merge] [release/3.0] Update dependencies from aspnet/Extensions Oct 4, 2019

wtgodbe mentioned this pull request Oct 4, 2019

Move pinned Microsoft.Netcore.App down dotnet/extensions#2456

Merged

dougbu suggested changes Oct 4, 2019

View reviewed changes

dotnet-maestro Bot changed the title ~~[do not merge] [release/3.0] Update dependencies from aspnet/Extensions~~ [release/3.0] Update dependencies from aspnet/Extensions Oct 4, 2019

Pin microsoft.netcore.app.ref to 3.0.0

0f4612c

wtgodbe approved these changes Oct 4, 2019

View reviewed changes

dougbu approved these changes Oct 4, 2019

View reviewed changes

wtgodbe merged commit 45facaf into release/3.0 Oct 5, 2019

wtgodbe deleted the darc-release/3.0-29824be8-f085-4c1f-be6b-471e4b9051a3 branch October 5, 2019 00:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/3.0] Update dependencies from aspnet/Extensions#18207

[release/3.0] Update dependencies from aspnet/Extensions#18207
wtgodbe merged 4 commits into
release/3.0from
darc-release/3.0-29824be8-f085-4c1f-be6b-471e4b9051a3

dotnet-maestro Bot commented Oct 3, 2019 •

edited

Loading

Uh oh!

dotnet-maestro Bot commented Oct 3, 2019 •

edited

Loading

Uh oh!

dougbu Oct 4, 2019

Uh oh!

wtgodbe Oct 4, 2019

Uh oh!

mmitche Oct 4, 2019

Uh oh!

dougbu Oct 4, 2019

Uh oh!

dougbu Oct 4, 2019

Uh oh!

dougbu commented Oct 4, 2019

Uh oh!

dotnet-maestro Bot commented Oct 4, 2019 •

edited

Loading

Uh oh!

dougbu left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dotnet-maestro Bot commented Oct 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/aspnet/Extensions

Coherency Updates

Uh oh!

dotnet-maestro Bot commented Oct 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

dougbu Oct 4, 2019

Choose a reason for hiding this comment

Uh oh!

wtgodbe Oct 4, 2019

Choose a reason for hiding this comment

Uh oh!

mmitche Oct 4, 2019

Choose a reason for hiding this comment

Uh oh!

dougbu Oct 4, 2019

Choose a reason for hiding this comment

Uh oh!

dougbu Oct 4, 2019

Choose a reason for hiding this comment

Uh oh!

dougbu commented Oct 4, 2019

Uh oh!

dotnet-maestro Bot commented Oct 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

dougbu left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dotnet-maestro Bot commented Oct 3, 2019 •

edited

Loading

dotnet-maestro Bot commented Oct 3, 2019 •

edited

Loading

dotnet-maestro Bot commented Oct 4, 2019 •

edited

Loading